Improve single test #44
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didn't convert the source, so that we don't end up having conflicts with other ongoing PRs. Change-type: patch
Change-type: patch Signed-off-by: Miguel Casqueira <[email protected]>
Change-type: patch Signed-off-by: Miguel Casqueira <[email protected]>
thgreasi
reviewed
May 21, 2020
Comment on lines
+106
to
+107
| constructor: (message = 'Error with API request', @response) -> | ||
| super(@message) |
There was a problem hiding this comment.
Suggested change
| constructor: (message = 'Error with API request', @response) -> | |
| super(@message) | |
| constructor: (message = 'Error with API request', @response) -> | |
| super(message) | |
| @message = message |
That's the simplest way to get this emit a valid build result, otherwise we can't pass @message to super(), since this is undefined at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR to improve on a test case that should have been added in PR #41.
I built this on top of another PR #43. If I cannot easily cleanup the commit history after that gets merged i'll just delete this branch and create another from master. This will remain a draft until then.