URL matching abstraction #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balazsgerlei
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Thank you very much for your contribution, I really like the concept and the fact that it provides more flexibility for defining allowed and disallowed URIs. It's a huge bonus that you made it possible to unit test it, it's been on my TODO list since I started working on this library and this is a good basis to build on!
I added my remarks and suggestions, please check them and implement them if you agree, while I'm always open for discussion! Thanks for your patience while waiting on my review I was struggling to fit it in.
library/src/test/java/dev/gerlot/securewebview/url/AnyUriMatcherTest.java
Outdated
Show resolved
Hide resolved
library/src/test/java/dev/gerlot/securewebview/url/AuthorityAndPathMatcherTest.java
Outdated
Show resolved
Hide resolved
library/src/test/java/dev/gerlot/securewebview/url/AuthorityContainmentMatcherTest.java
Outdated
Show resolved
Hide resolved
library/src/main/java/dev/gerlot/securewebview/url/AllowedUrlList.java
Outdated
Show resolved
Hide resolved
library/src/test/java/dev/gerlot/securewebview/url/AuthorityContainmentMatcherTest.java
Outdated
Show resolved
Hide resolved
library/src/test/java/dev/gerlot/securewebview/url/BeginningMatcherTest.java
Outdated
Show resolved
Hide resolved
library/src/test/java/dev/gerlot/securewebview/url/DeniedUrlListTest.java
Outdated
Show resolved
Hide resolved
drathar
force-pushed
the
18-url-matching-abstraction
branch
from
c5d2b09 to
be129ff
Compare
… iterate through the whole list
…ays iterate through the whole list
…t for both allowing and disallowing URIs
drathar
force-pushed
the
18-url-matching-abstraction
branch
from
ac85e3c to
13ef821
Compare
balazsgerlei
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposed alternative solution to #18.
I've created the
UrlMatcherinterface and various implementations for every possible value of theMatchVariantenumeration.I've also created the
DeniedUrlListandAllowedUrlListclasses both implementingUrlMatcherto be used as compound matchers instead of using aList<DisallowedUrl>andList<String>respectively. This gives a nice API and more freedom over the allow-list as not only host matching can be checked using theUrlMatcherinterface.If you don't like this kind of abstraction feel free to close my PR and the corresponding issue, otherwise any observations, suggestions, ideas, etc. are more than welcome. 👍🏻