Patch issues causing CoW Swap UX to break when loading the tokenlist #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken list. 1: Remove forbidden <> from osETH/ETH stablepool 2: Remove an number of instances of `"logoURI": "missing_large.png"`. This is not a valid URI, and other pools have no URI when an image is missing.
|
Ran a manual generate run here: https://github.com/balancer/tokenlists/actions/runs/11240180686 to test the end result of a regenerated token list. Will then have cowswap test on that artefact. If it works can move this PR out of draft. |
|
Found a few new images, but still created the missing_large.jpg file in some cases, and but back the <> |
|
Second test generation looks good: #1656 |
Xeonus
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1: Remove forbidden <> from osETH/ETH stablepool
2: Remove an number of instances of
"logoURI": "missing_large.png". This is not a valid URI, and other pools have no URI when an image is missing.Context: https://balancerecosystem.slack.com/archives/C035TDPHQAJ/p1728136137605379