Fix wpColorPicker Error #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2016
brknkfr
pushed a commit
to radiorabe/wordpress-theme-rabe
that referenced
this pull request
Dec 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND
$('.at-color')wpColorPicker()even if the user never instantiated a color field.wp-color-pickerlib only if the user instantiates a color field.PROBLEM
If the user doesn't have a color field, the main js file will always fail.
SOLUTION
Don't call
wpColorPicker()unless a color field is detected in the dom. If a color field was created using the api, there should be a color field in the DOM andwp-color-pickerwould be instantiated by the class.