Laravel 8 Support and Beyond #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ShawnMcCool, would you mind to review this PR? Thanks. |
robbielove
approved these changes
Dec 6, 2020
There was a problem hiding this comment.
I think these changes will work for future-proofing, however, it could cause issues - if 'breaking changes' are introduced;
On the other hand, we have to wait for the changes to be merged.
Perhaps consider giving @nafiesl and I; write permissions - to enable (quicker) merges...
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are adding support for laravel 8.x and beyond. It will work on the upcoming laravel major release as well.
This PR tested on laravel 8 on this project nafiesl/silsilah#61 (installed successfully, doing backup and restore in MySQL).