Upgrade for redmine 4.0.4

- Add sidekiq dependancy to GemFile
- Change deprecated method *_filter by *_action, it is the equivalent since Rails5.2
- Change css z-index to prevent search menu to pass under backlog menu

Gemfile

@@ -1,3 +1,4 @@
+gem "sidekiq"
 gem 'erubis', '~> 2.7'
 gem "holidays", "~>1.0.3"
 gem "icalendar"

app/controllers/rb_all_projects_controller.rb

@@ -1,7 +1,7 @@
 class RbAllProjectsController < ApplicationController
   unloadable
 
-  before_filter :authorize_global
+  before_action :authorize_global
 
   def statistics
     backlogs_projects = RbCommonHelper.find_backlogs_enabled_active_projects

app/controllers/rb_calendars_controller.rb

@@ -5,7 +5,7 @@ class RbCalendarsController < RbApplicationController
 
   case Backlogs.platform
     when :redmine
-      before_filter :require_admin_or_api_request, :only => :ical
+      before_action :require_admin_or_api_request, :only => :ical
       accept_api_auth :ical
     when :chiliproject
       accept_key_auth :ical

app/controllers/rb_impediments_controller.rb

@@ -4,7 +4,7 @@ class RbImpedimentsController < RbApplicationController
   unloadable
 
   def create
-    @settings = Backlogs.settings
+    @settings = Backlogs.setting
     begin
       @impediment = RbTask.create_with_relationships(params, User.current.id, @project.id, true)
     rescue => e
@@ -23,7 +23,7 @@ def create
 
   def update
     @impediment = RbTask.find_by_id(params[:id])
-    @settings = Backlogs.settings
+    @settings = Backlogs.setting
     begin
       result = @impediment.update_with_relationships(params)
     rescue => e

app/controllers/rb_releases_controller.rb

@@ -49,7 +49,7 @@ def edit
   def update
     except = ['id', 'project_id']
     attribs = params.select{|k,v| (!except.include? k) and (RbRelease.column_names.include? k) }
-    attribs = Hash[*attribs.flatten]
+    attribs = attribs.to_enum.to_h
     begin
       result  = @release.update_attributes attribs
     rescue => e

app/controllers/rb_sprints_controller.rb

@@ -12,7 +12,7 @@ class RbSprintsController < RbApplicationController
 
   def create
     attribs = params.select{|k,v| k != 'id' and RbSprint.column_names.include? k }
-    attribs = Hash[*attribs.flatten]
+    attribs = attribs.to_enum.to_h
     @sprint = RbSprint.new(attribs)
 
     #share the sprint according to the global setting
@@ -43,7 +43,7 @@ def create
   def update
     except = ['id', 'project_id']
     attribs = params.select{|k,v| (!except.include? k) and (RbSprint.column_names.include? k) }
-    attribs = Hash[*attribs.flatten]
+    attribs = attribs.to_enum.to_h
     begin
       result  = @sprint.update_attributes attribs
     rescue => e

app/controllers/rb_taskboards_controller.rb

@@ -7,7 +7,7 @@ def show
     stories = @sprint.stories
     @story_ids    = stories.map{|s| s.id}
 
-    @settings = Backlogs.settings
+    @settings = Backlogs.setting
 
     ## determine status columns to show
     tracker = Tracker.find_by_id(RbTask.tracker)

app/controllers/rb_tasks_controller.rb

@@ -4,11 +4,13 @@ class RbTasksController < RbApplicationController
   unloadable
 
   def create
-    @settings = Backlogs.settings
+    params.permit!
+    @settings = Backlogs.setting
     @task = nil
     begin
       @task  = RbTask.create_with_relationships(params, User.current.id, @project.id)
     rescue => e
+      Rails.logger.debug(e.to_yaml)
       render :text => e.message.blank? ? e.to_s : e.message, :status => 400
       return
     end
@@ -23,8 +25,9 @@ def create
   end
 
   def update
+    params.permit!
     @task = RbTask.find_by_id(params[:id])
-    @settings = Backlogs.settings
+    @settings = Backlogs.setting
     result = @task.update_with_relationships(params)
     status = (result ? 200 : 400)
     @include_meta = true

app/models/rb_story.rb

@@ -175,7 +175,7 @@ def self.create_and_position(params)
     attribs = params.select{|k,v| !['prev', 'next', 'id', 'lft', 'rgt'].include?(k) && RbStory.column_names.include?(k) }
 
     attribs[:status] = RbStory.class_default_status
-    attribs = attribs.to_enum.to_h#Hash[*attribs.flatten]
+    attribs = attribs.to_enum.to_h
     s = RbStory.new(attribs)
     s.save
     s.position!(params)

app/models/rb_task.rb

@@ -59,7 +59,7 @@ def self.rb_safe_attributes(params)
     attribs = params.select {|k,v| safe_attributes_names.include?(k) }
     # lft and rgt fields are handled by acts_as_nested_set
     attribs = attribs.select{|k,v| k != 'lft' and k != 'rgt' }
-    attribs = Hash[*attribs.flatten] if attribs.is_a?(Array)
+    attribs = attribs.to_enum.to_h if attribs.is_a?(Array)
     return attribs
   end
 

assets/stylesheets/global.css

@@ -30,7 +30,7 @@ a:hover{
   position:relative;
   width:100%;
   box-shadow: 0 3px 4px #A0A0A0;
-  z-index:1000;
+  z-index:98;
   border-radius: 10px;
 }
 #toolbar .breadcrumbs{

assets/stylesheets/taskboard.css

@@ -44,7 +44,7 @@ See RB.Taskboard.initialize()
   margin-bottom:0;
   margin-right:10px;
   position: absolute;
-  z-index: 200;
+  z-index: 100;
 }
 #board_header td{
   background-color:#EEEEEE;