Add GH actions workflow #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
force-pushed
the
fix/ci-github-actions
branch
from
8d1ac40 to
6ed7f2a
Compare
maurolacy
force-pushed
the
fix/ci-github-actions
branch
from
cca6783 to
58e77eb
Compare
SebastianElvis
requested changes
Aug 6, 2024
.github/workflows/benchmarking.yml
Outdated
Comment on lines
5
to
10
| env: | ||
| CARGO_TERM_COLOR: always | ||
| AWS_ACCESS_KEY_ID: xxxxYKF5 | ||
| AWS_REGION: xxxxst-1 | ||
| AWS_SECRET_ACCESS_KEY: xxxxmvcn | ||
| S3_BUCKET_PREFIX: xxxxract |
There was a problem hiding this comment.
Oh, how did you work this out?
.github/workflows/deploy.yml
Outdated
| # (github.ref == 'refs/tags//^v[0-9]+\.[0-9]+\.[0-9]+.*/') && (github.ref != 'refs/heads//.*/') | ||
| defaults: | ||
| run: | ||
| working-directory: "/home/circleci/project" |
There was a problem hiding this comment.
Hmm why is circleci relevant here?
There was a problem hiding this comment.
This is part of migration.
SebastianElvis
approved these changes
Aug 6, 2024
|
No worries. Will put this into good shape (working units tests workflow only), so that we can merge and have some tests. And then will work on integration / release workflows in a couple follow-ups. |
maurolacy
force-pushed
the
fix/ci-github-actions
branch
from
5275a1d to
c8b44e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #31.