Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Scripts/MagisterTerrace): Rescript Kael's intro #21278

Merged
merged 4 commits into from
Jan 27, 2025
Merged

fix(Scripts/MagisterTerrace): Rescript Kael's intro #21278

merged 4 commits into from
Jan 27, 2025
+55 −24

Conversation

Nyeriah
Copy link
Member

@Nyeriah Nyeriah commented Jan 27, 2025 •
edited
Loading

  • Kael only starts roleplay once all mobs in front of him die
  • Kael doesnt auto engage combat after roleplay
  • Added talk animation from sniffs

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added DB related to the SQL database Script file-cpp Used to trigger the matrix build labels Jan 27, 2025
@Nyeriah
Copy link
Member Author

Nyeriah commented Jan 27, 2025

Requires #21279

@Rorschach91 Rorschach91 merged commit ed99f05 into azerothcore:master Jan 27, 2025
13 checks passed
nl-saw added a commit to nl-saw/azerothcore-wotlk that referenced this pull request Jan 28, 2025
@nl-saw @ZhengPeiRu21
@kjack9 @liyunfan1223 @AlvinZhu @oiuv @MrSlntGhost @Garashan @noisiver @atidot3 @manstfu @hermensbas @Raz0r1337 @Nyeriah @Tereneckla @github-actions @sogladev @skelUA @blinkysc @TheSCREWEDSoftware @Exitare @Grimdhex @Rorschach91 @Kitzunu
Playerbots (#14)
7d6b7dd 
* Sync (#12)

* Update to be compatible with latest AC

* fix(Docker): add libboost-thread-dev dependency to Dockerfile

* feat: fix warning and configuration

* Prevent GUID from exhausting

* HandlePlayerLoginFromDB

* command setskill range allow 0

* spilit boss_heigan to .cpp and .h

* split grobbulus

* split heigan

* Spell(item check): turn ItemLevel to RequiredLevel

* split anubrekhan, grobbulus scripts

* logout bots in kickall

* refactor naxxramas

* Fix(scripts): bot receive CMSG packet

* conf for playerbots log

* change gitmodules

* MOD_PLAYERBOTS macro

* fix scripts issue

* playerbot logout

* Fix multi-language DBC loading

* Force playerbots locale enUS

* Fix ServerScript.h

* Fix docker load metadata error

* Split Ulduar's script files

Split Ulduar script .cpp files into .h and .cpp files.

* Revert "Split Ulduar's script files"

* Fix workflows

* Fix workflows

* Fix variable unused warning

* Update workflows

* Update core-build.yml

* Fix macos CI

* Fix macos CI

* Fix macos compilation

* CI ignore warnings

* Disable test build for macos CI

* Fix macos CI

* [Scripts] Naxxramas scripts refactor with namespace

* Rollback name check

* Playerbot fixes and functionnality to talk in channels

* Fix macos build

* Fix warnings

* Playerbot helper

* Add MoveKnockbackFromForPlayer

* fix chat warning

* Naxx scripts header

* Fix continuous integration workflow

* Revert "Merge branch 'master' into Playerbot"

This reverts commit 9973151, reversing
changes made to 6f5b504.

* Update PlayerQuest.cpp

Fixed spells not granted by quests

* Updated with master branch

* Revert "Revert "Merge branch 'master' into Playerbot""

This reverts commit 2358b25.

* Fix header include for playerbots

* placed sql into the data folder as core/module describes

* Update worldserver.conf.dist

logging stuff inserted into the correct area of ​​the config file

* Add a new statement to update character online by guid

* Add class and race to CHAR_SEL_CHARS_BY_ACCOUNT_ID

* Add MovePointBackwards in MotionMaster.h

---------

Co-authored-by: ZhengPeiRu21 <[email protected]>
Co-authored-by: 郑佩茹 <[email protected]>
Co-authored-by: KJack <[email protected]>
Co-authored-by: Yunfan Li <[email protected]>
Co-authored-by: Alvin Zhu <[email protected]>
Co-authored-by: Oiuv <[email protected]>
Co-authored-by: Yunfan Li <[email protected]>
Co-authored-by: MrSlntGhost <[email protected]>
Co-authored-by: Garashan <[email protected]>
Co-authored-by: antony <[email protected]>
Co-authored-by: Revision <[email protected]>
Co-authored-by: Atidot3 <[email protected]>
Co-authored-by: manstfu <[email protected]>
Co-authored-by: bash <[email protected]>
Co-authored-by: Sascha <[email protected]>

* fix(Scripts/MagisterTerrace): Fix Phoenixes and eggs not despawning (azerothcore#21260)

* fix(DB/Loot) Clean up loot of bosses in MGT HC (azerothcore#21262)

* chore(DB): import pending files

Referenced commit(s): c54de87

* fix(DB/Gameobject): remove extra Sanctum Planetarium (azerothcore#21251)

* chore(DB): import pending files

Referenced commit(s): d3cdd2f

* fix(Apps/Codestyle): ignore comments for some checks (azerothcore#21268)

* fix(DB/SAI): Correct Phoenix/Egg rebirth and combat behaviour (azerothcore#21261)

* chore(DB): import pending files

Referenced commit(s): f420195

* fix(Core/Auction):  Fix  usable item search in auction (azerothcore#21267)

* fix(Scripts/BlackTemple): Fix Gurtogg will not use acidic wound in phase 2 (azerothcore#21253)

* SECURITY.md File Update  (azerothcore#20190)

* feat(Core/Autobroacast): Add autobroadcast locale (azerothcore#20946)

* chore(DB): import pending files

Referenced commit(s): a74e06c

* feat(Core/Creatures): implement a sparring system (azerothcore#19824)

* chore(DB): import pending files

Referenced commit(s): edf2959

* fix(DB/Creature) Several Dragonflayers now have a SmartAI. (azerothcore#21275)

* chore(DB): import pending files

Referenced commit(s): f824f15

* fix(DB/SAI) - Fixes quest Counterattack! sometimes not being completed and adds 1 ability to the creature. (azerothcore#21050)

* chore(DB): import pending files

Referenced commit(s): dc0f77e

* feat(Core/Unit): Implement SetEmoteState() and ClearEmoteState() helpers (azerothcore#21279)

* refactor(Core/Motd): improve and simplify (azerothcore#21252)

* chore(DB): import pending files

Referenced commit(s): 9b3d54d

* fix(Scripts/MagisterTerrace): Rescript Kael's intro (azerothcore#21278)

* chore(DB): import pending files

Referenced commit(s): ed99f05

* fix(DB/SAI) Fix Amani Trainer Abilities (azerothcore#21269)

* chore(DB): import pending files

Referenced commit(s): 33eedba

* fix(DB/Creature) Update Amani Trainer SmartAI comments. (azerothcore#21282)

* chore(DB): import pending files

Referenced commit(s): 1c036f6

---------

Co-authored-by: ZhengPeiRu21 <[email protected]>
Co-authored-by: 郑佩茹 <[email protected]>
Co-authored-by: KJack <[email protected]>
Co-authored-by: Yunfan Li <[email protected]>
Co-authored-by: Alvin Zhu <[email protected]>
Co-authored-by: Oiuv <[email protected]>
Co-authored-by: Yunfan Li <[email protected]>
Co-authored-by: MrSlntGhost <[email protected]>
Co-authored-by: Garashan <[email protected]>
Co-authored-by: antony <[email protected]>
Co-authored-by: Revision <[email protected]>
Co-authored-by: Atidot3 <[email protected]>
Co-authored-by: manstfu <[email protected]>
Co-authored-by: bash <[email protected]>
Co-authored-by: Sascha <[email protected]>
Co-authored-by: Andrew <[email protected]>
Co-authored-by: Tereneckla <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jelle Meeus <[email protected]>
Co-authored-by: skelUA <[email protected]>
Co-authored-by: blinkysc <[email protected]>
Co-authored-by: Ryan Turner <[email protected]>
Co-authored-by: Exitare <[email protected]>
Co-authored-by: Grimdhex <[email protected]>
Co-authored-by: Rocco Silipo <[email protected]>
Co-authored-by: Kitzunu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rorschach91 Rorschach91 Rorschach91 approved these changes

Assignees
No one assigned
Labels
DB related to the SQL database file-cpp Used to trigger the matrix build Ready to be Reviewed Script To Be Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyeriah @Rorschach91