Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/SAI) Quest Feedin' Da Goolz (12652) #21264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

p-tkachuk
Copy link

@p-tkachuk p-tkachuk commented Jan 24, 2025

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

Quest: https://www.wowhead.com/wotlk/quest=12652/feedin-da-goolz
Same ghoul can be feed more than once. So quest completion can be achieved by just spamming quest item near same ghoul.

This PR:

  • Replaces core script with SmartAI
  • ensures that same ghoul can not be feed again and again

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  1. .additem 38699 // choker
  2. .go xyz 4968 -1660 241
  3. use Choker
  4. .quest add 12652
    Go and do the quest - use quest item https://www.wowhead.com/wotlk/item=38701/bowels-and-brains-bowl near ghouls. Same ghoul should not be feedable two times in a row (without the delay).

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added DB related to the SQL database Script file-cpp Used to trigger the matrix build labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database file-cpp Used to trigger the matrix build Script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant