fix(Scripts/Zulaman) Multiple fixes to Jan'alai

[blinkysc]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes [Zul'Aman] Jan'alai's wrong behaviors when he start bombing #21125
• Additionally changed Flame Breath to 1.5 seconds based on the video evidence
• Created new SpawnBombs() so that bomb spread is more Blizzlike based on video evidence

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. .go c id 23578
2. 57 seconds before middle
3. wait 3 seconds before start throwing bombs for 5 seconds
4. Restart bombing 30 seconds
5. .die while throwing bombs to ensure full reset

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[blinkysc]

Honestly still not quite happy with SpawnBombs(). Was going for something like a circle spreading from the center and that area being the potential for random bomb with the max circle being the arena and max time the 5 seconds... Maybe I'll keep poking at it but does certainly look more blizzlike then before.

[amed80]

Jan'alai still stay in the middle until the bombs explodes.
After throwing bombs ,he shouldn't wait for the bombs to explode, he should stop doing his animation and start attacking the target again.

[blinkysc]

Jan'alai still stay in the middle until the bombs explodes. After throwing bombs ,he shouldn't wait for the bombs to explode, he should stop doing his animation and start attacking the target again.

I see what you mean, I made another commit to make him start attacking 1s before boom

[amed80]

I believe it should be 3s at least before the bombs explode (so L341 from 8s down to 6s?) but everything else seems to be working fine :)

[blinkysc]

I believe it should be 3s at least before the bombs explode (so L341 from 8s down to 6s?) but everything else seems to be working fine :)

Watched the youtubes again... Agreed, made the commit for da boom

[amed80]

@blinkysc 21266 ?

[blinkysc]

@blinkysc 21266 ?

Im tired lol

[blinkysc]

Ready for review