fix(Scripts/BT) Fix Gurtogg will not use acidic wound in phase 2 #21253

blinkysc · 2025-01-23T23:54:41Z

Changes Proposed:

This PR proposes changes to:

Core (units, players, creatures, game systems).
Scripts (bosses, spell scripts, creature scripts).
Database (SAI, creatures, etc).

Issues Addressed:

Closes [Black Temple] Boss: Gurtogg Bloodboil shouldn't apply Acidic Wound in Phase 2 #21204

SOURCE:

The changes have been validated through:

Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
Sniffs (remember to share them with the open source community!)
Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

Tested in-game by the author.
Tested in-game by other community members/someone else other than the author/has been live on production servers.
This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

This pull request can be tested by following the reproduction steps provided in the linked issue
This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Use bots or other players so no reset during bewildering strikes
.go c id 22948
Wait for fel rage and observe no acid wound
After fel rage acid wound should be used again

Known Issues and TODO List:

[ ]
[ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

removed redundant RemoveAura

Nyeriah · 2025-01-24T01:08:43Z

Ive explained the issue in detail here: #21208 (comment)

I am not certain how giving him the aura again would be able to address this issue

blinkysc · 2025-01-24T01:32:05Z

Ive explained the issue in detail here: #21208 (comment)

I am not certain how giving him the aura again would be able to address this issue

Honestly not sure why that's the case as well, I took this from the original script and applied it to when fel rage happens with 28s timer (based on fel rage instead of checking if any player has it). I have tested and works but I'll keep looking for a more appropriately named function

Updated old and new with DoCastVictim()

blinkysc · 2025-01-24T01:44:52Z

So apparently DoCastVictim() works the same here ¯\(ツ)/¯, I changed the old line of code as well. Also tested again

Nyeriah · 2025-01-24T02:39:49Z

So apparently DoCastVictim() works the same here ¯_(ツ)_/¯, I changed the old line of code as well. Also tested again

Effect 0: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = I
Targets (1, 0) (TARGET_UNIT_CASTER, NO_TARGET)

40484 has TARGET_UNIT_CASTER as target so it has only one valid target, himself. So DoCastSelf() is the appropriate choice here

Back to DoCastSelf()

blinkysc · 2025-01-24T02:57:43Z

So apparently DoCastVictim() works the same here ¯_(ツ)_/¯, I changed the old line of code as well. Also tested again

Effect 0: Id 6 (SPELL_EFFECT_APPLY_AURA) BasePoints = I Targets (1, 0) (TARGET_UNIT_CASTER, NO_TARGET)

40484 has TARGET_UNIT_CASTER as target so it has only one valid target, himself. So DoCastSelf() is the appropriate choice here

DoCastSelf() back

amed80 · 2025-01-24T06:39:47Z

Gurtogg still uses acidic wound in phase 2.

blinkysc · 2025-01-24T12:53:48Z

Gurtogg still uses acidic wound in phase 2.

Tried another 2 times, but I don't ever see Gurtogg apply acidic wound while fel rage. Do you see the same behavior before or any difference?

Nyeriah · 2025-01-24T13:27:17Z

Do you have uncommited changes by any chance?

amed80 · 2025-01-24T13:38:02Z

Gurtogg still uses acidic wound in phase 2.

Tried another 2 times, but I don't ever see Gurtogg apply acidic wound while fel rage. Do you see the same behavior before or any difference?

tested again
i see same behavior before and after the PR

AzerothCore rev. a13c2ff+ 2025-01-23 17:30:31 +0000 (master branch) (Win64, RelWithDebInfo, Static)

No modules are enabled

blinkysc · 2025-01-24T13:48:48Z

Gurtogg still uses acidic wound in phase 2.

Tried another 2 times, but I don't ever see Gurtogg apply acidic wound while fel rage. Do you see the same behavior before or any difference?

tested again i see same behavior before and after the PR

AzerothCore rev. a13c2ff+ 2025-01-23 17:30:31 +0000 (master branch) (Win64, RelWithDebInfo, Static)

No modules are enabled

You'll have to checkout the PR before testing, unless of course you just copy pasta?

https://graphite.dev/guides/git-checkout-pr

Nyeriah · 2025-01-24T13:53:15Z

Remove the aura at start of p2

blinkysc · 2025-01-24T14:03:04Z

Remove the aura at start of p2

Acidic Wound shouldn't be removed from players if I'm not mistaken just that new applications should not be applied?
https://www.youtube.com/watch?v=yPaj1Wpd6cE -> around 1:28 you can see player still has debuff with fel rage

Nyeriah · 2025-01-24T14:04:43Z

yes... I mean.. from the boss..

amed80 · 2025-01-24T14:09:54Z

You'll have to checkout the PR before testing, unless of course you just copy pasta?

https://graphite.dev/guides/git-checkout-pr

usually do it manually but tried again

AzerothCore rev. dffb89b 2025-01-23 20:57:24 -0600 (pr-21253 branch) (Win64, RelWithDebInfo, Static)

Acidic.mp4

blinkysc · 2025-01-24T14:15:49Z

yes... I mean.. from the boss..

Boss never has the Aura, that was the confusion with DoCastSelf() even though its an offensive ability (from Gurtogg's perspective)

blinkysc · 2025-01-24T14:21:55Z

You'll have to checkout the PR before testing, unless of course you just copy pasta?
https://graphite.dev/guides/git-checkout-pr

usually do it manually but tried again

AzerothCore rev. dffb89b 2025-01-23 20:57:24 -0600 (pr-21253 branch) (Win64, RelWithDebInfo, Static)
Acidic.mp4

Oh I see, maybe weird timing issue. Maybe what I can do is something like 100-300ms before fel rage he stops acidic wound and maybe 100ms after?

blinkysc · 2025-01-24T14:22:33Z

Also @amed80 no more is applied after that initial one right? During Fel Rage that is

amed80 · 2025-01-24T14:24:26Z

it keeps applying for the whole phase 2

blinkysc · 2025-01-24T14:34:24Z

it keeps applying for the whole phase 2

Mind trying again with this commit?

Nyeriah · 2025-01-24T14:35:17Z

Gurtogg casts the aura (SPELL_ACIDIC_WOUND) on himself on pull, the aura then triggers the application as long as he has the aura.

blinkysc · 2025-01-24T14:41:48Z

Gurtogg casts the aura (SPELL_ACIDIC_WOUND) on himself on pull, the aura then triggers the application as long as he has the aura.

I see ok let me fix that

src/server/scripts/Outland/BlackTemple/boss_bloodboil.cpp

EricksOliveira · 2025-01-24T15:07:51Z

This problem is quite intriguing. I haven't had time to fix my commit, but I believe the best way to fix this problem is to create phases on the boss. I'll be looking into this tomorrow, when I'm less busy at work.

blinkysc · 2025-01-24T15:11:18Z

I've tried and tried but from what I see acid wound isn't happening to players in Phase 2 with latest commit. The Aura is removed on Gurtogg during Phase 2 and he waits 28s to reapply. What you think @Nyeriah ?

RemoveAurasDueToSpell

blinkysc · 2025-01-24T15:32:17Z

@amed80 if you woundn't mind trying again when you have a chance

amed80 · 2025-01-24T15:42:07Z

Yes , tested 3 Fel Rage phases.
He doesn't apply it during p2 and he applies it again after going back to p1.

EricksOliveira · 2025-01-25T22:07:35Z

Strange. I tested it and it didn't turn out as expected.
After phase 2, Acidic wound did not activate again for me.

amed80 · 2025-01-25T22:29:14Z

Just tested it after this got merged, it seems fine to me?

AzerothCore rev. d297030 2025-01-25 19:06:21 -0300 (master branch) (Win64, RelWithDebInfo, Static)

AcidicW.mp4

* Sync (#12) * Update to be compatible with latest AC * fix(Docker): add libboost-thread-dev dependency to Dockerfile * feat: fix warning and configuration * Prevent GUID from exhausting * HandlePlayerLoginFromDB * command setskill range allow 0 * spilit boss_heigan to .cpp and .h * split grobbulus * split heigan * Spell(item check): turn ItemLevel to RequiredLevel * split anubrekhan, grobbulus scripts * logout bots in kickall * refactor naxxramas * Fix(scripts): bot receive CMSG packet * conf for playerbots log * change gitmodules * MOD_PLAYERBOTS macro * fix scripts issue * playerbot logout * Fix multi-language DBC loading * Force playerbots locale enUS * Fix ServerScript.h * Fix docker load metadata error * Split Ulduar's script files Split Ulduar script .cpp files into .h and .cpp files. * Revert "Split Ulduar's script files" * Fix workflows * Fix workflows * Fix variable unused warning * Update workflows * Update core-build.yml * Fix macos CI * Fix macos CI * Fix macos compilation * CI ignore warnings * Disable test build for macos CI * Fix macos CI * [Scripts] Naxxramas scripts refactor with namespace * Rollback name check * Playerbot fixes and functionnality to talk in channels * Fix macos build * Fix warnings * Playerbot helper * Add MoveKnockbackFromForPlayer * fix chat warning * Naxx scripts header * Fix continuous integration workflow * Revert "Merge branch 'master' into Playerbot" This reverts commit 9973151, reversing changes made to 6f5b504. * Update PlayerQuest.cpp Fixed spells not granted by quests * Updated with master branch * Revert "Revert "Merge branch 'master' into Playerbot"" This reverts commit 2358b25. * Fix header include for playerbots * placed sql into the data folder as core/module describes * Update worldserver.conf.dist logging stuff inserted into the correct area of the config file * Add a new statement to update character online by guid * Add class and race to CHAR_SEL_CHARS_BY_ACCOUNT_ID * Add MovePointBackwards in MotionMaster.h --------- Co-authored-by: ZhengPeiRu21 <[email protected]> Co-authored-by: 郑佩茹 <[email protected]> Co-authored-by: KJack <[email protected]> Co-authored-by: Yunfan Li <[email protected]> Co-authored-by: Alvin Zhu <[email protected]> Co-authored-by: Oiuv <[email protected]> Co-authored-by: Yunfan Li <[email protected]> Co-authored-by: MrSlntGhost <[email protected]> Co-authored-by: Garashan <[email protected]> Co-authored-by: antony <[email protected]> Co-authored-by: Revision <[email protected]> Co-authored-by: Atidot3 <[email protected]> Co-authored-by: manstfu <[email protected]> Co-authored-by: bash <[email protected]> Co-authored-by: Sascha <[email protected]> * fix(Scripts/MagisterTerrace): Fix Phoenixes and eggs not despawning (azerothcore#21260) * fix(DB/Loot) Clean up loot of bosses in MGT HC (azerothcore#21262) * chore(DB): import pending files Referenced commit(s): c54de87 * fix(DB/Gameobject): remove extra Sanctum Planetarium (azerothcore#21251) * chore(DB): import pending files Referenced commit(s): d3cdd2f * fix(Apps/Codestyle): ignore comments for some checks (azerothcore#21268) * fix(DB/SAI): Correct Phoenix/Egg rebirth and combat behaviour (azerothcore#21261) * chore(DB): import pending files Referenced commit(s): f420195 * fix(Core/Auction): Fix usable item search in auction (azerothcore#21267) * fix(Scripts/BlackTemple): Fix Gurtogg will not use acidic wound in phase 2 (azerothcore#21253) * SECURITY.md File Update (azerothcore#20190) * feat(Core/Autobroacast): Add autobroadcast locale (azerothcore#20946) * chore(DB): import pending files Referenced commit(s): a74e06c * feat(Core/Creatures): implement a sparring system (azerothcore#19824) * chore(DB): import pending files Referenced commit(s): edf2959 * fix(DB/Creature) Several Dragonflayers now have a SmartAI. (azerothcore#21275) * chore(DB): import pending files Referenced commit(s): f824f15 * fix(DB/SAI) - Fixes quest Counterattack! sometimes not being completed and adds 1 ability to the creature. (azerothcore#21050) * chore(DB): import pending files Referenced commit(s): dc0f77e * feat(Core/Unit): Implement SetEmoteState() and ClearEmoteState() helpers (azerothcore#21279) * refactor(Core/Motd): improve and simplify (azerothcore#21252) * chore(DB): import pending files Referenced commit(s): 9b3d54d * fix(Scripts/MagisterTerrace): Rescript Kael's intro (azerothcore#21278) * chore(DB): import pending files Referenced commit(s): ed99f05 * fix(DB/SAI) Fix Amani Trainer Abilities (azerothcore#21269) * chore(DB): import pending files Referenced commit(s): 33eedba * fix(DB/Creature) Update Amani Trainer SmartAI comments. (azerothcore#21282) * chore(DB): import pending files Referenced commit(s): 1c036f6 --------- Co-authored-by: ZhengPeiRu21 <[email protected]> Co-authored-by: 郑佩茹 <[email protected]> Co-authored-by: KJack <[email protected]> Co-authored-by: Yunfan Li <[email protected]> Co-authored-by: Alvin Zhu <[email protected]> Co-authored-by: Oiuv <[email protected]> Co-authored-by: Yunfan Li <[email protected]> Co-authored-by: MrSlntGhost <[email protected]> Co-authored-by: Garashan <[email protected]> Co-authored-by: antony <[email protected]> Co-authored-by: Revision <[email protected]> Co-authored-by: Atidot3 <[email protected]> Co-authored-by: manstfu <[email protected]> Co-authored-by: bash <[email protected]> Co-authored-by: Sascha <[email protected]> Co-authored-by: Andrew <[email protected]> Co-authored-by: Tereneckla <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jelle Meeus <[email protected]> Co-authored-by: skelUA <[email protected]> Co-authored-by: blinkysc <[email protected]> Co-authored-by: Ryan Turner <[email protected]> Co-authored-by: Exitare <[email protected]> Co-authored-by: Grimdhex <[email protected]> Co-authored-by: Rocco Silipo <[email protected]> Co-authored-by: Kitzunu <[email protected]>

blinkysc added 5 commits January 23, 2025 17:02

Update boss_bloodboil.cpp

518f7e6

Update boss_bloodboil.cpp

3d8d3c2

Update boss_bloodboil.cpp

d165961

Update boss_bloodboil.cpp

469ae9c

Update boss_bloodboil.cpp

723c42b

blinkysc mentioned this pull request Jan 23, 2025

[Black Temple] Boss: Gurtogg Bloodboil shouldn't apply Acidic Wound in Phase 2 #21204

Closed

github-actions bot added Script file-cpp Used to trigger the matrix build labels Jan 23, 2025

blinkysc mentioned this pull request Jan 23, 2025

fix(Core/Scripts) Fixes the misuse of the "Acidic Wound" skill in Phase 2 #21208

Closed

7 tasks

Update boss_bloodboil.cpp

eb32ffe

removed redundant RemoveAura

Update boss_bloodboil.cpp

ee813a3

Updated old and new with DoCastVictim()

Update boss_bloodboil.cpp

dffb89b

Back to DoCastSelf()

Nyeriah added Waiting to be Tested Ready to be Reviewed labels Jan 24, 2025

Update boss_bloodboil.cpp

8e2fa6d

Nyeriah reviewed Jan 24, 2025

View reviewed changes

src/server/scripts/Outland/BlackTemple/boss_bloodboil.cpp Outdated Show resolved Hide resolved

Nyeriah reviewed Jan 24, 2025

View reviewed changes

src/server/scripts/Outland/BlackTemple/boss_bloodboil.cpp Outdated Show resolved Hide resolved

Nyeriah reviewed Jan 24, 2025

View reviewed changes

src/server/scripts/Outland/BlackTemple/boss_bloodboil.cpp Outdated Show resolved Hide resolved

blinkysc added 2 commits January 24, 2025 08:48

Update boss_bloodboil.cpp

13fbab4

Update boss_bloodboil.cpp

3287676

Update boss_bloodboil.cpp

72322cc

RemoveAurasDueToSpell

Merge branch 'master' into GurtoggFix

1c75d1e

Nyeriah approved these changes Jan 25, 2025

View reviewed changes

Nyeriah merged commit d297030 into azerothcore:master Jan 25, 2025
12 checks passed

zhangbo8418 mentioned this pull request Jan 25, 2025

fix(Scripts/BlackTemple): Fix Gurtogg will not use acidic wound in ph… zhangbo8418/azerothcore-wotlk#38

Merged

12 tasks

TheSCREWEDSoftware mentioned this pull request Feb 3, 2025

[Black Temple] Gurtogg Bloodboil applies Acidic Wound in P2 chromiecraft/chromiecraft#7674

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Scripts/BT) Fix Gurtogg will not use acidic wound in phase 2 #21253

fix(Scripts/BT) Fix Gurtogg will not use acidic wound in phase 2 #21253

blinkysc commented Jan 23, 2025 •

edited

Loading

Nyeriah commented Jan 24, 2025

blinkysc commented Jan 24, 2025

blinkysc commented Jan 24, 2025 •

edited

Loading

Nyeriah commented Jan 24, 2025

blinkysc commented Jan 24, 2025

amed80 commented Jan 24, 2025

blinkysc commented Jan 24, 2025

Nyeriah commented Jan 24, 2025

amed80 commented Jan 24, 2025

blinkysc commented Jan 24, 2025 •

edited

Loading

Nyeriah commented Jan 24, 2025

blinkysc commented Jan 24, 2025 •

edited

Loading

Nyeriah commented Jan 24, 2025

amed80 commented Jan 24, 2025

blinkysc commented Jan 24, 2025

blinkysc commented Jan 24, 2025

blinkysc commented Jan 24, 2025 •

edited

Loading

amed80 commented Jan 24, 2025

blinkysc commented Jan 24, 2025

Nyeriah commented Jan 24, 2025

blinkysc commented Jan 24, 2025

EricksOliveira commented Jan 24, 2025

blinkysc commented Jan 24, 2025 •

edited

Loading

blinkysc commented Jan 24, 2025

amed80 commented Jan 24, 2025

EricksOliveira commented Jan 25, 2025 •

edited

Loading

amed80 commented Jan 25, 2025

fix(Scripts/BT) Fix Gurtogg will not use acidic wound in phase 2 #21253

fix(Scripts/BT) Fix Gurtogg will not use acidic wound in phase 2 #21253

Conversation

blinkysc commented Jan 23, 2025 • edited Loading

Changes Proposed:

Issues Addressed:

SOURCE:

Tests Performed:

How to Test the Changes:

Known Issues and TODO List:

How to Test AzerothCore PRs

Nyeriah commented Jan 24, 2025

blinkysc commented Jan 24, 2025

blinkysc commented Jan 24, 2025 • edited Loading

Nyeriah commented Jan 24, 2025

blinkysc commented Jan 24, 2025

amed80 commented Jan 24, 2025

blinkysc commented Jan 24, 2025

Nyeriah commented Jan 24, 2025

amed80 commented Jan 24, 2025

blinkysc commented Jan 24, 2025 • edited Loading

Nyeriah commented Jan 24, 2025

blinkysc commented Jan 24, 2025 • edited Loading

Nyeriah commented Jan 24, 2025

amed80 commented Jan 24, 2025

blinkysc commented Jan 24, 2025

blinkysc commented Jan 24, 2025

blinkysc commented Jan 24, 2025 • edited Loading

amed80 commented Jan 24, 2025

blinkysc commented Jan 24, 2025

Nyeriah commented Jan 24, 2025

blinkysc commented Jan 24, 2025

EricksOliveira commented Jan 24, 2025

blinkysc commented Jan 24, 2025 • edited Loading

blinkysc commented Jan 24, 2025

amed80 commented Jan 24, 2025

EricksOliveira commented Jan 25, 2025 • edited Loading

amed80 commented Jan 25, 2025

blinkysc commented Jan 23, 2025 •

edited

Loading

blinkysc commented Jan 24, 2025 •

edited

Loading

blinkysc commented Jan 24, 2025 •

edited

Loading

blinkysc commented Jan 24, 2025 •

edited

Loading

blinkysc commented Jan 24, 2025 •

edited

Loading

blinkysc commented Jan 24, 2025 •

edited

Loading

EricksOliveira commented Jan 25, 2025 •

edited

Loading