fix(Scripts/Hyjal): Fix hyjal trash

[Exitare]

I replaced the static fix with a dynamic one, that only triggers for the first wave for the first boss. Which is in my understanding Winterchill. All subsequent encounters will always apply rep gain.

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes Mount Hyjal, Wave 9 of Hyjal invaders doesnt give you reputation chromiecraft/chromiecraft#7684

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Two ways to tests: (Both must pass)

1. Start a new raid, kill the first wave (No rep gain). Play until the first boss spawns, kill it. Start next wave counter. The first wave should now provide rep.

2. Start a new raid, kill the first wave (No rep gain). Kill the first boss. Do no start the next wave counter. Leave the raid or restart the server. The event needs to be interrupted. Restart the server, start the new wave timer. First new wave should provide rep.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[sogladev]

I can't find any flaws with the logic 👍 I feel it should work as expected

Others have commented on formatting. I found the "Hide whitespace" button makes this much easier to review.

The original case labels are preferred https://www.azerothcore.org/wiki/cpp-code-standards

switch (spells)
{
    case SPELL_1:

Could you revert the case indents and consider the other comment I left?

[sogladev]

I see you extracted and created void ResetWaves() to avoid duplication. This feels to me like a good place to use [[fallthrough]] instead

Suggested change

	break;
	[[fallthrough]];

[Exitare]

I will work on it