Wallclocktime strftime #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
wallclocktime-strftime
branch
2 times, most recently
from
f0e1333 to
aef73cf
Compare
|
This would have been really useful for me today. |
MrAnno
force-pushed
the
wallclocktime-strftime
branch
from
aef73cf to
cea82c9
Compare
commit: 0784374d561435f7c787a555aeab8ede699ed29 tag: v1.2.5 Signed-off-by: László Várady <[email protected]>
This patch ports the musl strftime() implementation into wallclocktime, trying to minimize changes. Changes include: 1) added '%f' format specifier 2) use the "fake" locale already in the file because of strptime() 3) changed '%z' to use the timezone offset without ':' and '%Z' for a timezone offset with ':' We never emit timezone names. Signed-off-by: Balazs Scheidler <[email protected]>
MrAnno
force-pushed
the
wallclocktime-strftime
branch
from
cea82c9 to
07d3aa4
Compare
Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
wallclocktime-strftime
branch
from
07d3aa4 to
d322f19
Compare
MrAnno
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls the strftime() implementation from musl and exposes it using the strftime() filterx function.
This adds '%f' and the %z/%Z behaviour similar to what strptime() can easily parse.
@jszigetvari