Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filterx func str performance improvements #472

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Filterx func str performance improvements #472

wants to merge 2 commits into from

Conversation

bazsi
Copy link
Member

@bazsi bazsi commented Jan 24, 2025

This improves test coverage for startswith/endswith/includes as well as includes their performance by:

  • not using dynamically allocated GString and GPtrArray instances
  • using the glibc provided strstr() call instead of the one in glib

@bazsi
filterx/func-str: use strstr() from libc instead of glib
a6a744c 
It uses a better algorithm (both glibc and musl).

Signed-off-by: Balazs Scheidler <[email protected]>
@bazsi bazsi force-pushed the filterx-func-str-performance-improvements branch from 31c4be9 to f776307 Compare January 24, 2025 20:43
@bazsi bazsi force-pushed the filterx-func-str-performance-improvements branch from f776307 to d8c0bbd Compare January 24, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bazsi