filterx: use "type" as a description to FilterXExpr type #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bazsi
force-pushed
the
filterx-expr-add-type-field
branch
from
1431a7a to
a3a47ff
Compare
This was referenced Jan 7, 2025
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
filterx-expr-add-type-field
branch
from
a3a47ff to
47a5239
Compare
OverOrion
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted this patch from #423 so that we can build changes that build on this specific patch and can be merged independently of #423.
The point of this patch is to add a new "type" member into FilterXExpr, a string that can be used in various log messages.
I used this to initialize metrics in #423 but I might need it for identifying expr types instead of the "eval" function pointer in #433. Other than that I have a few other patches that change the expr constructors and simply started depending on this change as a part of their diff context.