sui integration #464
sui integration #464
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -34,13 +34,18 @@ | |||
| "release": "tsx scripts/release.ts" | |||
| }, | |||
| "dependencies": { | |||
| "@axelar-network/axelar-cgp-sui": "0.0.0-snapshot.424bc13", | |||
There was a problem hiding this comment.
@npty - what is the correct version we should be using for this now?
| const updatedComputed = { | ||
| ...computed, | ||
| indexedByChainId: { | ||
| ...computed.indexedByChainId, |
There was a problem hiding this comment.
@SGiaccobasso why is this hard coded here?
| @@ -76,6 +76,45 @@ export const ALL_CHAINS: ExtendedWagmiChainConfig[] = [ | |||
| axelarChainName: "ethereum", | |||
| environment: ENVIRONMENTS.mainnet, | |||
| }, | |||
| // TODO: correct this | |||
| { | |||
| id: 101, | |||
There was a problem hiding this comment.
since Sui isn't an EVM chain, we should either create a separate sui config file or rename thsi file
|
|
||
| await recordDeploymentDraft(); | ||
| if (chainId === SUI_CHAIN_ID && input) { |
There was a problem hiding this comment.
this callback can probably be generalized as a named function that's imported here rather than an inline "if-else" for Sui
| console.log("rootState.selectedChains", rootState.selectedChains); | ||
|
|
||
| // Sui will return a digest equivalent to the txHash | ||
| const SUI_CHAIN_ID = NEXT_PUBLIC_NETWORK_ENV === "mainnet" ? 101 : 103; |
There was a problem hiding this comment.
why is the Sui handler that much more complex than the EVM handler in this case? the EVM handler seems to only setTxState to idle, whereasyou're also invoking an addTransaction function here for SUi
Co-authored-by: npty <[email protected]>
Co-authored-by: SGiaccobasso <[email protected]>
No description provided.