Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bedrock): add default prompt router #882

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

aws-rafams
Copy link
Contributor

@aws-rafams aws-rafams commented Jan 7, 2025

Fixes #841

Default Prompt Routers are now supported in Prompt Management

CDK usage:

model: PromptRouter.fromDefaultId(DefaultPromptRouterIdentifier.ANTHROPIC_CLAUDE_V1, region)
Screenshot 2025-01-07 at 15 11 01 Invoke succeeds: Screenshot 2025-01-07 at 15 11 28

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@krokoko
Copy link
Collaborator

krokoko commented Jan 7, 2025

Thanks @aws-rafams ! Waiting for the build to finish but looks good to me ! 2 things we can add here:

  • CDK released the v2.174.1 which should fix the go packaging issue, we can upgrade it here <- done
  • Add a code snippet to the Bedrock README to provide more info on this feature <- done

Copy link
Contributor

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

mergify bot commented Jan 7, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #882 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information.)

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@krokoko krokoko merged commit 132eb07 into awslabs:main Jan 7, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bedrock): default prompt router
4 participants