Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(construct): Update file transformation changes in constructs #44

Merged
merged 14 commits into from
Oct 20, 2023

Conversation

dineshSajwan
Copy link
Contributor

Fixes #

  • Update summary schema to support array of files with each file response
  • Removed custom name from security group to avoid stack update failure.
  • Update summary lambda function to return proper error message in response.
  • Update summary step function to support vaild fail scenarios.
  • Update bucket permission in ingestion construct
  • update ingestion to name files differently.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/common/helpers/redis-helper.ts 96.24% <100.00%> (-0.24%) ⬇️
...patterns/gen-ai/aws-qa-appsync-opensearch/index.ts 97.62% <100.00%> (+0.08%) ⬆️
.../gen-ai/aws-rag-appsync-stepfn-opensearch/index.ts 97.69% <100.00%> (+0.17%) ⬆️
...s/gen-ai/aws-summarization-appsync-stepfn/index.ts 97.86% <100.00%> (-0.04%) ⬇️

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@laithalsaadoon laithalsaadoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krokoko krokoko merged commit 87ce0f6 into main Oct 20, 2023
@krokoko krokoko deleted the feature/file_transformation branch October 20, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants