fix: Trim whitespace before parsing Version

awslabs · Jan 14, 2025 · 5e60901 · 5e60901
1 parent 906d432
commit 5e60901
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/AWSSDKSwiftCLI/Sources/AWSCLIUtils/Version.swift b/AWSSDKSwiftCLI/Sources/AWSCLIUtils/Version.swift
@@ -22,7 +22,7 @@ public struct Version: Equatable {
     }
 
     public init(_ value: String) throws {
-        let components = value.split(separator: ".")
+        let components = value.trimmingCharacters(in: .whitespacesAndNewlines).split(separator: ".")
         guard components.count == 3 else {
             throw Error("Version does not have three components")
         }

diff --git a/AWSSDKSwiftCLI/Tests/AWSSDKSwiftCLITests/Utils/VersionUtilsTests.swift b/AWSSDKSwiftCLI/Tests/AWSSDKSwiftCLITests/Utils/VersionUtilsTests.swift
@@ -10,7 +10,14 @@ import AWSCLIUtils
 import XCTest
 
 class VersionUtilsTests: XCTestCase {
-
+
+    func testIgnoresLeadingAndTrailingWhitespace() throws {
+        try XCTAssertEqual(
+            Version("\r\n\t 1.2.1\r\n\t "),
+            Version("1.2.1")
+        )
+    }
+
     func testIncrementingMajor() throws {
         try XCTAssertEqual(
             Version("1.2.1").incrementingMajor(),