Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java V2 Add Amazon ECR Basic Scenario files. #6541

Merged
merged 55 commits into from
Jul 1, 2024
Merged

Java V2 Add Amazon ECR Basic Scenario files. #6541

merged 55 commits into from
Jul 1, 2024

Conversation

scmacdon
Copy link
Contributor

This pull request add Amazon ECR Basic Scenario files.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scmacdon scmacdon added Java-v2 This issue relates to the AWS SDK for Java V2 Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs. labels Jun 13, 2024
@scmacdon scmacdon self-assigned this Jun 13, 2024
@scmacdon scmacdon mentioned this pull request Jun 13, 2024
3 tasks
.doc_gen/metadata/ecr_metadata.yaml Outdated Show resolved Hide resolved
.doc_gen/metadata/ecr_metadata.yaml Outdated Show resolved Hide resolved
.doc_gen/metadata/ecr_metadata.yaml Show resolved Hide resolved
getting_started_scenarios/ecr_scenario/README.md Outdated Show resolved Hide resolved
getting_started_scenarios/ecr_scenario/README.md Outdated Show resolved Hide resolved
getting_started_scenarios/ecr_scenario/README.md Outdated Show resolved Hide resolved
javav2/example_code/ecr/src/test/java/ECRTest.java Outdated Show resolved Hide resolved
Copy link
Contributor

@cpyle0819 cpyle0819 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few change requests.

@scmacdon scmacdon added the On Call Review needed This work needs an on-call review label Jun 28, 2024
@beqqrry-aws beqqrry-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Jul 1, 2024
@beqqrry-aws beqqrry-aws merged commit de8aa8c into awsdocs:main Jul 1, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java-v2 This issue relates to the AWS SDK for Java V2 On Call Review complete On call review complete Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants