Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Repo w/ Go Modules and Add Darwin arm64 support #11

Closed
wants to merge 2 commits into from

Conversation

bwagner5
Copy link

@bwagner5 bwagner5 commented Sep 3, 2021

Issue #, if available:
#1
#9

Description of changes:

  • Move go src and repo structure to a more conventional and modern go structure
    • Move any main packages to the top-level cmd dir
    • Upgrade go build version to 1.16
    • Use go modules (using the repo as the module name) and remove all checked-in vendor deps
    • Remove unmaintained uuid lib and replace w/ google/uuid
  • Support Darwin arm64 builds and packaging
  • Make bash packaging scripts safer by exiting if an error occurs w/ set -euo pipefail
  • Add proper github PR template w/ correct license
  • Add github actions workflow w/ checkstyle and quick-test targets to check PRs automatically

Testing:

  • make checkstyle quick-test PASSED
  • make build-darwin-arm64 package-darwin-arm64 PASSED
  • Built binary and tested connecting an ec2-instance. PASSED

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bwagner5 bwagner5 changed the title Go mod Restructure Repo w/ Go Modules and Add Darwin arm64 support Sep 3, 2021
@cguertin14
Copy link

+5000 files changed, there might be a problem somewhere? just wondering.

@bwagner5
Copy link
Author

@cguertin14 Hi! The 5,000 files changed are mainly removing the vendor (dependency source code) checked in to this repo in favor of using Go modules to pull dependencies at compile time.

@phene
Copy link

phene commented Feb 8, 2022

Any chance of this getting updated with resolved conflicts and merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants