chore: increase open file size limit to 40k for chat context #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently Q chat open file size context is limited to 9000 characters, which truncates a lot of context for larger files. This PR aims to increase the size to 40000 characters.
One thing to note from the constructor of DocumentContextExtractor is config?.characterLimits will always be undefined as only logger is passed while initializing the constructor. Hence, directly updating the DEFAULT_CHARACTER_LIMIT constant value
this.#characterLimits = config?.characterLimits ?? DocumentContextExtractor.DEFAULT_CHARACTER_LIMITAs of now, this does not relate to or involve any A/B testing as it has not yet been confirmed to be done for VS and Eclipse (the two IDEs which consume Flare to deliver capabilities). Current change will set the character limit to 40K for every request.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.