Add support for Memgraph and supply chain notebook #522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new PR to add support for the Memgraph database without formatting changes. While fixing this, I fixed a couple of other things I noticed, so it turned out to be a good thing to check it.
I added
README
to the additional databases folder to show that connecting to Memgraph is achievable via the existing Neo4j setup. But, since it's not intuitive for the users to set a username and password for the neo4j configuration setting, I createdMemgraphSection
in the configuration and exposedusername
,password
,auth
anddatabase
configuration flags. I addeddatabase
section too, because Memgraph released a multitenancy feature in v2.10.I also updated the
README
in the root folder accordingly.Since I added Memgraph as an additional database, I also decided to contribute with a notebook.
I would like to add that I missed local testing instructions to be sure all is alright, but I did test the connection to Memgraph and run queries from the Supply Chain Analysis notebook.
Let me know what I need to do else in order to get this PR merged and I will be more than happy to contribute more.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.