Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FixUnmarshalIndividualSetValues option to DecoderOptions of dynamodb #2896

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AnatolyRugalev
Copy link

Fixes #2895

@AnatolyRugalev
Copy link
Author

I am not sure how to add a changelog record. Feel free to take over this PR

@lucix-aws
Copy link
Contributor

JFYI we still plan to review/approve this, but it may have to wait until after the Thanksgiving week.

@Madrigal
Copy link
Contributor

Madrigal commented Jan 8, 2025

We recently added instructions on how to generate a changelog entry for PRs. In the past, we had to do this on behalf of contributors, slowing down the review process. Can you go through this document and generate a changelog entry for this PR?

@lucix-aws
Copy link
Contributor

Ping @AnatolyRugalev, please see previous comment about adding a changelog

@AnatolyRugalev AnatolyRugalev changed the title fix(dynamodb): fix StringSet, NumberSet and BinarySet decoding Add FixUnmarshalIndividualSetValues option to DecoderOptions of dynamodb Jan 22, 2025
@AnatolyRugalev
Copy link
Author

Sorry, I was on holidays and missed your message. I added the changlog as instructed and rebased the branch. Since this change is opt-in, I am marking my change as a feature instead of a bugfix. Let me know if you want me to change that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dynamodb: StringSet and StringSet decoders call unmarshaller incorrectly
3 participants