Print warning to stdout #6233
Open
Print warning to stdout #6233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the use of `pcluster dcv-connect -n <cluster> | pbcopy` to copy the url directly into macOS paste buffer.
gmarciani
reviewed
May 2, 2024
| @@ -64,10 +64,11 @@ def _dcv_connect(args): | |||
|
|
|||
| try: | |||
| url = _retry(_retrieve_dcv_session_url, func_args=[cmd, args.cluster_name, head_node_ip], attempts=4) | |||
| url_message = f"Please use the following one-time URL in your browser within 30 seconds:\n{url}" | |||
| url_message = f"Please use the following one-time URL in your browser within 30 seconds:" | |||
There was a problem hiding this comment.
There is a test that should be changed accordingly:
aws-parallelcluster/tests/integration-tests/tests/dcv/test_dcv.py
Lines 76 to 79 in ea57725
gmarciani
reviewed
May 2, 2024
| @@ -64,10 +64,11 @@ def _dcv_connect(args): | |||
|
|
|||
| try: | |||
| url = _retry(_retrieve_dcv_session_url, func_args=[cmd, args.cluster_name, head_node_ip], attempts=4) | |||
| url_message = f"Please use the following one-time URL in your browser within 30 seconds:\n{url}" | |||
| url_message = f"Please use the following one-time URL in your browser within 30 seconds:" | |||
There was a problem hiding this comment.
With this change we are removing an explicative message from stdout to make it easier to consume the url.
What if this command returns a JSON, such as:
{
"message": "Please use the following one-time URL in your browser within 30 seconds",
"url": "https://...."
}
This would be consistent with the other pcluster commands returning JSON and would make possible to consume the url easily with jq or, even better, with the --query option of the pcluster CLI.
What do you think?
There was a problem hiding this comment.
Sounds good to me. Please feel free to change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
pcluster dcv-connect -n <cluster> | pbcopyto copy the url directly into macOS paste buffer.