fix: unload: Cleanup active domains and endpoints #768
+154
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauteric
reviewed
Jan 21, 2025
mozarhua
force-pushed
the
cleanup-domain-ep-at-unload
branch
from
ac07303 to
a12f6ff
Compare
|
bot:aws:retest |
2 similar comments
|
bot:aws:retest |
|
bot:aws:retest |
mozarhua
force-pushed
the
cleanup-domain-ep-at-unload
branch
from
a12f6ff to
e7161a0
Compare
bwbarrett
requested changes
Jan 23, 2025
mozarhua
force-pushed
the
cleanup-domain-ep-at-unload
branch
2 times, most recently
from
245d2fe to
88e21bc
Compare
bwbarrett
reviewed
Jan 28, 2025
mozarhua
force-pushed
the
cleanup-domain-ep-at-unload
branch
from
88e21bc to
02b3309
Compare
bwbarrett
previously approved these changes
Jan 29, 2025
mozarhua
force-pushed
the
cleanup-domain-ep-at-unload
branch
from
02b3309 to
65aa4d7
Compare
bwbarrett
previously approved these changes
Jan 29, 2025
rauteric
previously approved these changes
Jan 30, 2025
When aborting with no connection established, there were QPs leaked if any domain and endpoint left open. This patch adds domain and endpoint cleanup logic at the beginning of rdma and sendrecv device release to prevent the QP leak. Note the logic can be triggered without aws#772. Signed-off-by: Mozar Huang <[email protected]>
mozarhua
force-pushed
the
cleanup-domain-ep-at-unload
branch
from
65aa4d7 to
c0c6df9
Compare
rauteric
approved these changes
Jan 30, 2025
bwbarrett
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When aborting with no connection established, there were QPs leaked if any domain and endpoint left open.
This patch adds domain and endpoint cleanup logic at the beginning of rdma and sendrecv device release (which will be called by
nccl_net_ofi_plugin_fini()for each device) to prevent the QP leak.Note the logic can be triggered without #772.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.