Build plugins as DSOs intead of shared libraries. #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add libpthread to the library list, so it will be directly linked in both the net plugin and executables. The plugin uses pthreads, so should have been including this by default. We got lucky because the pthread calls were in something we were building as a .so and not in the unit tests. But breaking that in a future commit breaks the getting lucky part of the equation. Signed-off-by: Brian Barrett <[email protected]>
rauteric
reviewed
Apr 8, 2024
Build the plugins (tuner and net) as DSOs instead of shared libraries by adding the `-module -avoid-version` flags to the library LDFLAGS. Of course, now that the net plugin is not a shared library, we can't link against it in the tests. Rather than build a bunch of infrastructure to dlopen() the net plugin (which would mean all kinds of fun path work to make "make check" work), build the net plugin by creating a helper library that contains all the source, and building the net plugin from that. Now the helper library can be used to static link the plugin into the tests (both functional and unit). Signed-off-by: Brian Barrett <[email protected]>
bwbarrett
force-pushed
the
bugfix/build-plugins-as-dsos
branch
from
f83ae77 to
a4f1819
Compare
rauteric
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the plugins (tuner and net) as DSOs instead of shared libraries by adding the
-module -avoid-versionflags to the library LDFLAGS.Fix up a couple of issues that fall out of that change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.