Skip to content

Commit

Permalink
packaging: add a hack for efa-config/libfabric
Browse files Browse the repository at this point in the history
efa-config is necessary to populate ldconfig cache for libfabric, rather
than libfabric specifying this itself. This means its insufficient for
aws-ofi-nccl to simply depend on libfabric, because pulling in libfabric
as a build dependency doesn't pull in efa-config, which is necessary to
actually resolve the library. Add a gross hack that runs the entire
build with LD_LIBRARY_PATH set. It's an understatement to say that this
is not ideal.

Signed-off-by: Nicholas Sielicki <[email protected]>
  • Loading branch information
aws-nslick committed Dec 12, 2024
1 parent 75b31d0 commit a70d5bf
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion contrib/debian-template/rules
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,9 @@ override_dh_auto_configure:
--disable-tests \
--disable-werror

#%:
# dh $@
# this is a hack to work around efa-installer diamond dependency with
# efa-config/libfabric-aws and should be removed.
%:
dh $@
LD_LIBRARY_PATH=/opt/amazon/efa/lib:${LD_LIBRARY_PATH} dh $@

0 comments on commit a70d5bf

Please sign in to comment.