Skip to content

Commit

Permalink
fix(param): move some parameters to unsigned
Browse files Browse the repository at this point in the history
mr_key_size and eager_max_size are positive integers, avoid sign
comparison issues by treating them as such.

stack-info: PR: #571, branch: aws-nslick/stack/18
  • Loading branch information
aws-nslick committed Sep 4, 2024
1 parent c91092a commit 5fbcb38
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions include/nccl_ofi_param.h
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ OFI_NCCL_PARAM_INT(cuda_flush_enable, "CUDA_FLUSH_ENABLE", 0);
* Specify the memory registration key size in bytes when using a libfabric
* provider that supports application-selected memory registration keys.
*/
OFI_NCCL_PARAM_INT(mr_key_size, "MR_KEY_SIZE", 2);
OFI_NCCL_PARAM_UINT(mr_key_size, "MR_KEY_SIZE", 2);

/*
* Disable the MR cache. The MR cache is used to keep track of registered
Expand Down Expand Up @@ -244,7 +244,7 @@ OFI_NCCL_PARAM_INT(net_latency, "NET_LATENCY", -1);
* tweak defaults from the platform file, but this fits our needs for
* now.
*/
OFI_NCCL_PARAM_INT(eager_max_size, "EAGER_MAX_SIZE",
OFI_NCCL_PARAM_UINT(eager_max_size, "EAGER_MAX_SIZE",
#if HAVE_NEURON
0
#else
Expand Down

0 comments on commit 5fbcb38

Please sign in to comment.