Add filtering before DeleteOrEvictPods #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiationg-kho
force-pushed
the
1097-daemon
branch
from
b1ccf6f to
dc2c91a
Compare
Add a unit test case for FilterOutDaemonSetPods method. |
LikithaVemulapalli
approved these changes
Dec 31, 2024
| }, | ||
| }, | ||
| }, | ||
| } |
There was a problem hiding this comment.
nit: indentation seems off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1097
Description of changes:
How you tested your changes:
Environment (Linux / Windows): Linux
Kubernetes Version: 1.31
Set
use-apiserver-cache: trueandemit-kubernetes-events: truethen toggle theignore-daemon-setsflag to test protect daemonset pods or not.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.