Add SQS InterruptionEvent.InstanceType #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hari-rad thanks for making this PR. Could you also make sure to make changes to e2e tests to ensure your changes pass? You can also run e2e tests locally using make e2e-test. |
|
I had a look at the Contributing process. Please let me know if I need to create an Issue for this. Hope this could be included in a future release. |
Lu-David
approved these changes
Dec 30, 2024
|
Yes! We'll include this in our next release! Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature - would like to expose the InstanceType also in the webhook notifications
Changes - Updated getNodeInfo to return the InstanceType
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.