Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set default checksum if request_checksum_calculation config is set to when_supported #9238

Merged

Conversation

jonathan343
Copy link
Contributor

AWS CLI v2 version of boto/s3transfer#329

Addresses: boto/s3transfer#327

This PR checks the request_checksum_calculation config on the S3 client before setting a default checksum for both non-MPU and MPU. If request_checksum_calculation is set to when_supported, the default checksum from botocore (currently CRC32) is applied. If request_checksum_calculation is set to when_required, no default checksum is applied.

@jonathan343 jonathan343 merged commit c7340a4 into aws:v2 Jan 23, 2025
40 of 45 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (6323bb6) to head (e165279).
Report is 54 commits behind head on v2.

Additional details and impacted files
@@    Coverage Diff     @@
##   v2   #9238   +/-   ##
==========================
==========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants