chore(toolkit): consistent durations and error codes #33287
Conversation
| const stacks = assembly.selectStacksV2(options.stacks); | ||
| await this.validateStacksMetadata(stacks, ioHost); | ||
| const synthTime = timer.end(); | ||
| await ioHost.notify(info(`\n✨ Synthesis time: ${synthTime.asSec}s\n`, 'CDK_TOOLKIT_I5001', { |
There was a problem hiding this comment.
This changes the code to CDK_TOOLKIT_I1000 which is the universal code for synth time.
mrgrain
force-pushed
the
mrgrain/chore/toolkit/emit-more-times
branch
from
562d794 to
842fbf9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33287 +/- ##
=======================================
Coverage 80.80% 80.80%
=======================================
Files 236 236
Lines 14235 14235
Branches 2487 2487
=======================================
Hits 11503 11503
Misses 2448 2448
Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mrgrain
force-pushed
the
mrgrain/chore/toolkit/emit-more-times
branch
from
842fbf9 to
c50edfe
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| // Synth | ||
| CDK_TOOLKIT_I1000: 'Provides synthesis times', | ||
| CDK_TOOLKIT_I1901: 'Provides stack data', | ||
| CDK_TOOLKIT_I1902: 'Successfully deployed stacks', |
There was a problem hiding this comment.
Is there a way to codify these rules, i.e. that Synth messages must start with 1XXX, better than the honor system we're employing right now?
There was a problem hiding this comment.
I don't really know how to unfortunately.
There was a problem hiding this comment.
Fair. I thought about it some and I couldn't think of anything reasonable without supplying additional information into the record set similar to how lambda runtimes work. i.e. static readonly CDK_TOOLKIT_I1000 = new Code('synth', 'Provides synthesis times')
But i think its not worth investigating further so i'm approving.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Issue #33255
Closes #33255
Reason for this change
Introducing consistent duration messages.
Description of changes
timetodurationon timings/duration messages.Describe any new or updated permissions being added
n/a
Description of how you validated changes
existing tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license