Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigatewayv2): stage support detailedMetricsEnabled property #33267

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

phuhung273
Copy link
Contributor

Issue # (if applicable)

Closes #33222

Reason for this change

Missing detailedMetricsEnabled property

Description of changes

Stage support detailedMetricsEnabled property

Describe any new or updated permissions being added

Description of how you validated changes

Unit + Integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Feb 1, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 1, 2025 03:46
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Feb 1, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 1, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (1c98881) to head (f597616).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33267   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files         236      236           
  Lines       14253    14253           
  Branches     2490     2490           
=======================================
  Hits        11522    11522           
  Misses       2446     2446           
  Partials      285      285           
Flag Coverage Δ
suite.unit 80.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.57% <ø> (ø)
packages/aws-cdk-lib/core 82.20% <ø> (ø)

@phuhung273
Copy link
Contributor Author

Hmmm, something wrong with integ test
@aws-cdk/aws-iot-actions-alpha:   ERROR      cloudwatch/integ.cloudwatch-put-metric-action 2.666s
@aws-cdk/aws-iot-actions-alpha:       "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha:   If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha:       /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha:   Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha:   ERROR      cloudwatch/integ.cloudwatch-logs-action 2.673s
@aws-cdk/aws-iot-actions-alpha:       "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha:   If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha:       /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha:   Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha:   ERROR      lambda/integ.lambda-function-action 2.58s
@aws-cdk/aws-iot-actions-alpha:       "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha:   If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha:       /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha:   Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha:   ERROR      kinesis-stream/integ.kinesis-put-record-action 2.727s
@aws-cdk/aws-iot-actions-alpha:       "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha:   If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha:       /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha:   Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-kinesis-stream-action-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha:   ERROR      cloudwatch/integ.cloudwatch-set-alarm-state-action 2.638s
@aws-cdk/aws-iot-actions-alpha:       "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha:   If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha:       /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha:   Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha:   ERROR      s3/integ.s3-put-object-action 2.68s
@aws-cdk/aws-iot-actions-alpha:       "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha:   If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha:       /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha:   Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha:   ERROR      sqs/integ.sqs-queue-action 2.606s
@aws-cdk/aws-iot-actions-alpha:       "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha:   If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha:       /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha:   Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha:   ERROR      iot/integ.iot-republish-action 2.801s
@aws-cdk/aws-iot-actions-alpha:       "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha:   If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha:       /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha:   Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK iot-republish-action-test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha:   ERROR      sns/integ.sns-topic-action 2.707s
@aws-cdk/aws-iot-actions-alpha:       "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha:   If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha:       /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha:   Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK sns-topic-action-test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha:   ERROR      kinesis-firehose/integ.firehose-put-record-action 2.882s
@aws-cdk/aws-iot-actions-alpha:       "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha:   If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha:       /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha:   Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha: Snapshot Results: 
@aws-cdk/aws-iot-actions-alpha: Tests:    10 failed, 15 total
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/cloudwatch/integ.cloudwatch-logs-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/cloudwatch/integ.cloudwatch-put-metric-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/cloudwatch/integ.cloudwatch-set-alarm-state-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/iot/integ.iot-republish-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/kinesis-firehose/integ.firehose-put-record-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/kinesis-stream/integ.kinesis-put-record-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/lambda/integ.lambda-function-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/s3/integ.s3-put-object-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/sns/integ.sns-topic-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/sqs/integ.sqs-queue-action.js

Working fine on my machine
image

@badmintoncryer
Copy link
Contributor

@phuhung273 Could you please merge main branch? When tests or CI that are unrelated to your own changes fail, it usually resolves itself just by doing that.

@phuhung273
Copy link
Contributor Author

@phuhung273 Could you please merge main branch? When tests or CI that are unrelated to your own changes fail, it usually resolves itself just by doing that.

That works, really appreciate @badmintoncryer 👍

Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left only a minor comment and will approve this after the unit tests are updated.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 6, 2025
Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 7, 2025
@aaythapa aaythapa self-assigned this Feb 7, 2025
aaythapa
aaythapa previously approved these changes Feb 7, 2025
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

mergify bot commented Feb 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Feb 7, 2025
Copy link
Contributor

mergify bot commented Feb 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@moelasmar
Copy link
Contributor

@mergify update

Copy link
Contributor

mergify bot commented Feb 7, 2025

update

☑️ Nothing to do

  • queue-position = -1 [📌 update requirement]
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

Copy link
Contributor

mergify bot commented Feb 7, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #33267 has been manually updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot dismissed aaythapa’s stale review February 7, 2025 06:51

Pull request has been modified.

Copy link
Contributor

mergify bot commented Feb 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Feb 7, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Feb 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f597616
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0abcacf into aws:main Feb 7, 2025
20 checks passed
Copy link

github-actions bot commented Feb 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
@phuhung273 phuhung273 deleted the apigw-detailmetrics branch February 7, 2025 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk-lib.aws_apigatewayv2: Missing DetailedMetricsEnabled option
5 participants