-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apigatewayv2): stage support detailedMetricsEnabled
property
#33267
Conversation
6e67f56
to
7cc9c6b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33267 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 236 236
Lines 14253 14253
Branches 2490 2490
=======================================
Hits 11522 11522
Misses 2446 2446
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hmmm, something wrong with integ test@aws-cdk/aws-iot-actions-alpha: ERROR cloudwatch/integ.cloudwatch-put-metric-action 2.666s
@aws-cdk/aws-iot-actions-alpha: "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha: If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha: /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha: Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha: ERROR cloudwatch/integ.cloudwatch-logs-action 2.673s
@aws-cdk/aws-iot-actions-alpha: "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha: If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha: /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha: Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha: ERROR lambda/integ.lambda-function-action 2.58s
@aws-cdk/aws-iot-actions-alpha: "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha: If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha: /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha: Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha: ERROR kinesis-stream/integ.kinesis-put-record-action 2.727s
@aws-cdk/aws-iot-actions-alpha: "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha: If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha: /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha: Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-kinesis-stream-action-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha: ERROR cloudwatch/integ.cloudwatch-set-alarm-state-action 2.638s
@aws-cdk/aws-iot-actions-alpha: "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha: If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha: /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha: Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha: ERROR s3/integ.s3-put-object-action 2.68s
@aws-cdk/aws-iot-actions-alpha: "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha: If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha: /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha: Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha: ERROR sqs/integ.sqs-queue-action 2.606s
@aws-cdk/aws-iot-actions-alpha: "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha: If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha: /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha: Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha: ERROR iot/integ.iot-republish-action 2.801s
@aws-cdk/aws-iot-actions-alpha: "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha: If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha: /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha: Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK iot-republish-action-test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha: ERROR sns/integ.sns-topic-action 2.707s
@aws-cdk/aws-iot-actions-alpha: "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha: If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha: /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha: Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK sns-topic-action-test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha: ERROR kinesis-firehose/integ.firehose-put-record-action 2.882s
@aws-cdk/aws-iot-actions-alpha: "cdk-integ" can only operate on apps with a single stack.
@aws-cdk/aws-iot-actions-alpha: If your app has multiple stacks, specify which stack to select by adding this to your test source:
@aws-cdk/aws-iot-actions-alpha: /// !cdk-integ STACK ...
@aws-cdk/aws-iot-actions-alpha: Available stacks: [SDK info] STS.GetCallerIdentity({}) -> OK test-stack (wildcards are also supported)
@aws-cdk/aws-iot-actions-alpha: Snapshot Results:
@aws-cdk/aws-iot-actions-alpha: Tests: 10 failed, 15 total
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/cloudwatch/integ.cloudwatch-logs-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/cloudwatch/integ.cloudwatch-put-metric-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/cloudwatch/integ.cloudwatch-set-alarm-state-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/iot/integ.iot-republish-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/kinesis-firehose/integ.firehose-put-record-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/kinesis-stream/integ.kinesis-put-record-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/lambda/integ.lambda-function-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/s3/integ.s3-put-object-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/sns/integ.sns-topic-action.js
@aws-cdk/aws-iot-actions-alpha: Failed: /codebuild/output/src1033380923/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-iot-actions-alpha/test/sqs/integ.sqs-queue-action.js |
@phuhung273 Could you please merge main branch? When tests or CI that are unrelated to your own changes fail, it usually resolves itself just by doing that. |
That works, really appreciate @badmintoncryer 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I left only a minor comment and will approve this after the unit tests are updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@mergify update |
☑️ Nothing to do
|
This pull request has been removed from the queue for the following reason: The pull request #33267 has been manually updated You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #33222
Reason for this change
Missing detailedMetricsEnabled property
Description of changes
Stage support
detailedMetricsEnabled
propertyDescribe any new or updated permissions being added
Description of how you validated changes
Unit + Integration test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license