feat: efm2 #371
Open
feat: efm2 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyc-bq
force-pushed
the
efm2
branch
3 times, most recently
from
765f928 to
cec0010
Compare
sophia-bq
reviewed
Jan 24, 2025
karenc-bq
reviewed
Jan 28, 2025
karenc-bq
reviewed
Jan 28, 2025
karenc-bq
reviewed
Jan 28, 2025
joyc-bq
force-pushed
the
efm2
branch
2 times, most recently
from
e7551a0 to
9c6277c
Compare
karenc-bq
reviewed
Feb 7, 2025
karenc-bq
reviewed
Feb 7, 2025
karenc-bq
reviewed
Feb 7, 2025
karenc-bq
reviewed
Feb 7, 2025
karenc-bq
reviewed
Feb 7, 2025
karenc-bq
approved these changes
Feb 7, 2025
|
EFM and EFM2 seem to be missing a piece of code converting |
karenc-bq
reviewed
Feb 7, 2025
karenc-bq
reviewed
Feb 7, 2025
karenc-bq
reviewed
Feb 8, 2025
Comment on lines
+55
to
+56
| const val = this.clientToAbortRef?.deref() ?? null; | ||
| return val !== null; |
There was a problem hiding this comment.
This is overcomplicated
Suggested change
| const val = this.clientToAbortRef?.deref() ?? null; | |
| return val !== null; | |
| return !!this.clientToAbortRef?.deref() |
karenc-bq
reviewed
Feb 8, 2025
| * | ||
| * @param clientToAbort A reference to the connection associated with this context that will be aborted. | ||
| */ | ||
| constructor(clientToAbort: any) { |
There was a problem hiding this comment.
The type of the client is known here, so we should not be using any
Suggested change
| constructor(clientToAbort: any) { | |
| constructor(clientToAbort: ClientWrapper) { |
karenc-bq
reviewed
Feb 8, 2025
| this.clientToAbortRef = null; | ||
| } | ||
|
|
||
| getClient(): ClientWrapper { |
There was a problem hiding this comment.
Suggested change
| getClient(): ClientWrapper { | |
| getClient(): ClientWrapper | null { |
karenc-bq
reviewed
Feb 8, 2025
|
|
||
| export interface MonitorService { | ||
| startMonitoring( | ||
| clientToAbort: any, |
There was a problem hiding this comment.
Suggested change
| clientToAbort: any, | |
| clientToAbort: ClientWrapper, |
karenc-bq
reviewed
Feb 8, 2025
| * @param context The {@link MonitorConnectionContext} representing a connection. | ||
| * @param clientToAbort A reference to the connection associated with this context that will be aborted. | ||
| */ | ||
| stopMonitoring(context: MonitorConnectionContext, clientToAbort: any): Promise<void>; |
There was a problem hiding this comment.
Suggested change
| stopMonitoring(context: MonitorConnectionContext, clientToAbort: any): Promise<void>; | |
| stopMonitoring(context: MonitorConnectionContext, clientToAbort: ClientWrapper): Promise<void>; |
karenc-bq
reviewed
Feb 8, 2025
| } | ||
|
|
||
| async startMonitoring( | ||
| clientToAbort: any, |
There was a problem hiding this comment.
Suggested change
| clientToAbort: any, | |
| clientToAbort: ClientWrapper, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.