test: close topology monitors before each test

aws · Jan 16, 2025 · 6f31328 · 6f31328
1 parent db91c85
commit 6f31328
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/wrapper/src/main/java/software/amazon/jdbc/Driver.java b/wrapper/src/main/java/software/amazon/jdbc/Driver.java
@@ -412,6 +412,7 @@ public static void releaseResources() {
     CustomEndpointPlugin.closeMonitors();
     HikariPoolsHolder.closeAllPools();
     HostResponseTimeServiceImpl.closeAllMonitors();
+    MonitoringRdsHostListProvider.closeAllMonitors();
     clearCaches();
   }
 }
diff --git a/...ain/java/software/amazon/jdbc/hostlistprovider/monitoring/ClusterTopologyMonitorImpl.java b/...ain/java/software/amazon/jdbc/hostlistprovider/monitoring/ClusterTopologyMonitorImpl.java
@@ -265,6 +265,7 @@ protected List<HostSpec> waitTillTopologyGetsUpdated(final long timeoutMs) throw
   @Override
   public void close() throws Exception {
     this.stop.set(true);
+    this.nodeThreadsStop.set(true);
 
     // It breaks a waiting/sleeping cycles in monitoring thread
     synchronized (this.requestToUpdateTopology) {
@@ -276,6 +277,8 @@ public void close() throws Exception {
     if (!this.monitorExecutor.awaitTermination(30, TimeUnit.SECONDS)) {
       this.monitorExecutor.shutdownNow();
     }
+
+    this.nodeThreads.clear();
   }
 
   @Override

diff --git a/.../java/software/amazon/jdbc/hostlistprovider/monitoring/MonitoringRdsHostListProvider.java b/.../java/software/amazon/jdbc/hostlistprovider/monitoring/MonitoringRdsHostListProvider.java
@@ -85,17 +85,8 @@ public MonitoringRdsHostListProvider(
         CLUSTER_TOPOLOGY_HIGH_REFRESH_RATE_MS.getLong(this.properties));
   }
 
-  /**
-   * Clear topology cache for the current cluster.
-   */
-  public void clear() {
-    topologyCache.remove(this.clusterId);
-  }
-
   public static void clearCache() {
-    topologyCache.clear();
-    primaryClusterIdCache.clear();
-    suggestedPrimaryClusterIdCache.clear();
+    clearAll();
   }
 
   public static void closeAllMonitors() {