-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting auto-scaling internal code #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the change looks fine. Two things though:
- Where is this logic placed? (console_handler.py#L123-L141)
- What testing has been done so far related to the autoscaling changes?
Ah, I missed this part.
This is still WIP, so testing is still on-going. I appreciate if you share some testing tips/DAGs that can help with this. |
@ashishgo-aws , I addressed all comments and updated the PR. Please take a look. Thanks! |
Issue #, if available: #46
Description of changes: This PR ports the internal code we have related to auto-scaling. It ensures graceful shutdown of workers in case of auto-scaling.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.