Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting auto-scaling internal code #84

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Porting auto-scaling internal code #84

merged 1 commit into from
Jun 24, 2024

Conversation

rafidka
Copy link
Contributor

@rafidka rafidka commented Jun 18, 2024

Issue #, if available: #46

Description of changes: This PR ports the internal code we have related to auto-scaling. It ensures graceful shutdown of workers in case of auto-scaling.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@ashishgo-aws ashishgo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the change looks fine. Two things though:

  1. Where is this logic placed? (console_handler.py#L123-L141)
  2. What testing has been done so far related to the autoscaling changes?

images/airflow/2.9.2/python/mwaa/entrypoint.py Outdated Show resolved Hide resolved
@rafidka
Copy link
Contributor Author

rafidka commented Jun 18, 2024

@ashishgo-aws

Overall, the change looks fine. Two things though:

1. Where is this logic placed? https://code.amazon.com/packages/AWSPinwheelImages/blobs/66f9433e722b91e4d01a517c13b5ba23b874dcc2/--/images/airflow/2.8.1/logs/console_handler.py#L123-L141

Ah, I missed this part.

2. What testing has been done so far related to the autoscaling changes?

This is still WIP, so testing is still on-going. I appreciate if you share some testing tips/DAGs that can help with this.

@rafidka rafidka changed the title [WIP] Auto scaling Porting auto-scaling internal code Jun 21, 2024
@rafidka
Copy link
Contributor Author

rafidka commented Jun 21, 2024

@ashishgo-aws , I addressed all comments and updated the PR. Please take a look. Thanks!

@rafidka rafidka requested review from ashishgo-aws and Kalhan22 and removed request for dhegberg June 24, 2024 17:40
@rafidka rafidka merged commit bf83f07 into aws:main Jun 24, 2024
1 check passed
@Mercury2699 Mercury2699 deleted the auto-scaling branch June 24, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants