Make DB condition informational + Log sniffing #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `AirflowDbReachableCondition` would result in a container restart if there is a problem reaching the database. While this is the desired result eventually, I am changing it for now to be informational only, i.e. report connection problem, for two reasons: 1. This is the current behaviour in our internal images, so we want to reduce how much we deviate from it. 2. More importantly, a restart would need to be a bit more intelligent to avoid unnecessary restarts, which results in a considerable wait time while the container is being replaced. The re-introduction of restarts will be tracked in Issue #75. Along with this PR, I also re-introduced the generation of processable logs to capture the DB health metrics in the MWAA service. Finally, the PR also includes the porting of the log sniffing logic to detect common Airflow problems.
kuyperse
reviewed
Jun 14, 2024
kuyperse
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Previously,
AirflowDbReachableConditionwould result in a container restart if there is a problem reaching the database. While this is the desired result eventually, I am changing it for now to be informational only, i.e. report connection problem, for two reasons:The re-introduction of restarts will be tracked in Issue #75.
Along with this PR, I also re-introduced the generation of processable logs to capture the DB health metrics in the MWAA service.
Finally, the PR also includes the porting of the log sniffing logic to detect common Airflow problems.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.