Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding minor details to the build and run step within the README inst… #128

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

ashishgo-aws
Copy link
Contributor

Description of changes:

Adding a couple of additional details to the build and run step. The run.sh file require a few changes before it is ready to be executed and these steps are not present in the README file.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ashishgo-aws ashishgo-aws added the documentation Improvements or additions to documentation label Aug 7, 2024
@ashishgo-aws ashishgo-aws self-assigned this Aug 7, 2024
Copy link
Contributor

@dhegberg dhegberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we automate log group creation? Is there an issue for that?

@Mercury2699
Copy link

Should we automate log group creation? Is there an issue for that?

We have #129 to address this automation.

@dhegberg dhegberg merged commit 83874f0 into aws:main Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants