Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to aws-sdk-go-v2 #115

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Migrate to aws-sdk-go-v2 #115

merged 2 commits into from
Sep 27, 2024

Conversation

tinnywang
Copy link
Contributor

@tinnywang tinnywang commented Sep 23, 2024

Summary

Migrate to aws-sdk-go-v2 because aws-sdk-go will reach end of support on July 31, 2025.

Implementation details

Testing

make unit-test
make integration-test
make sudo-integraion-test
make e2e-test

In aws/amazon-ecs-agent#4349, amazon-ecs-cni-plugins submodule in amazon-ecs-agent to reference this branch. Ran functional tests on the PR and they passed.

New tests cover the changes: no

Description for the changelog

Migrate to aws-sdk-go-v2.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tinnywang tinnywang marked this pull request as ready for review September 23, 2024 22:43
@@ -423,28 +423,183 @@ github.com/aws/aws-sdk-go
limitations under the License.

***
github.com/boltdb/bolt

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is autogenerated, but do we know why this license is being removed? I think boltdb is still being used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BoltDB was removed in #113, specifically in 7ac5bce when updating to a newer version of docker/libkv. docker/libkv switched from BoltDB to BBolt in docker/libkv#202.

I didn't run make generate in #113 so BoltDB wasn't removed from the license until now. BBolt wasn't added because it's from go.etcd.io, and the license script currently only covers github.com and golang.org packages.

for registry in github.com golang.org; do
for user in ${vendor_relative_path}$registry/*; do
for repo in $user/*; do
if [[ $repo == *"go-buffruneio"* ]]; then
# nop, since we add this explicitliy
:
else
appendRepoLicense $repo
fi
done
done
done

@prateekchaudhry
Copy link

To clarify, I think aws/amazon-ecs-agent#4349 is testing against 8d91625 commit, is that right? Could you run a test with 4e2f3f2 as well?

@tinnywang
Copy link
Contributor Author

Updated aws/amazon-ecs-agent#4349 to test against 4e2f3f2.

Copy link

@mye956 mye956 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change! Also seems like session is no longer used in favor of config (link). Mind also including this in the PR description just so we can reference back to this for any future occurrences where we're migrating over to aws-sdk-go-v2?

@tinnywang tinnywang merged commit 7b4ec60 into aws:master Sep 27, 2024
@tinnywang tinnywang deleted the aws-sdk-go-v2 branch September 27, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants