Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): Add IoTCRUDEvent model #5892

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

basvandriel
Copy link

@basvandriel basvandriel commented Jan 21, 2025

Issue number: #5891

Summary

This implements the missing model for IoT registry events.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@basvandriel basvandriel requested a review from a team as a code owner January 21, 2025 10:54
Copy link

boring-cyborg bot commented Jan 21, 2025

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2025
@basvandriel basvandriel changed the title Add IoTCRUDEvent model feat(parser): Add IoTCRUDEvent model Jan 21, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 96.04%. Comparing base (54f9738) to head (5418544).

Files with missing lines Patch % Lines
...ols/utilities/parser/models/iot_core_crud_event.py 0.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5892      +/-   ##
===========================================
- Coverage    96.20%   96.04%   -0.16%     
===========================================
  Files          232      233       +1     
  Lines        10956    10974      +18     
  Branches      2027     2027              
===========================================
  Hits         10540    10540              
- Misses         327      345      +18     
  Partials        89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Feature request: Missing parser type for IoT Core events
2 participants