Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(event_handler): add type annotations for resolve function #5602

Merged

Conversation

rafrafek
Copy link
Contributor

@rafrafek rafrafek commented Nov 20, 2024

Issue number: #5600

Summary

Changes

  • Add type annotations for arguments in the ApiGatewayResolver.resolve function.

User experience

  • Static type checkers can see the correct type that is expected by the function when calling it.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2024
@rafrafek rafrafek marked this pull request as ready for review November 20, 2024 16:01
@rafrafek rafrafek requested a review from a team as a code owner November 20, 2024 16:01
@github-actions github-actions bot added the internal Maintenance changes label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (6ccc140) to head (787b870).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5602   +/-   ##
========================================
  Coverage    96.14%   96.14%           
========================================
  Files          229      229           
  Lines        10854    10854           
  Branches      2018     2018           
========================================
  Hits         10436    10436           
  Misses         329      329           
  Partials        89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@leandrodamascena leandrodamascena changed the title chore(resolver): add type annotations for ApiGatewayResolver.resolve refactor(event_handler): add type annotations for resolve function Nov 20, 2024
@github-actions github-actions bot added enhancement and removed internal Maintenance changes labels Nov 20, 2024
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED!

@leandrodamascena leandrodamascena self-assigned this Nov 21, 2024
@leandrodamascena leandrodamascena merged commit 9483bd3 into aws-powertools:develop Nov 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement event_handlers size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static typing: ‎ApiGatewayResolver.resolve‎ is missing type annotations
2 participants