refactor(middleware_factory): add from __future__ import annotations #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and update code according to ruff rules TCH, UP006, UP007, UP037 and FA100.
pull-request-size
bot
added
the
size/XS
leandrodamascena
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Hi @ericbn! What do you think about changing the examples related to Middleware Factory? I know there are dozens of files to change in all the other PRs you opened, but we can divide and conquer to make it faster. I can modify the examples and fix highlights, does that make sense?
2 tasks
|
@leandrodamascena, sure let’s divide and conquer, and you can modify the examples and highlights. Sounds great! I’ll take a look at the absolute imports soon. |
boring-cyborg
bot
added
the
documentation
pull-request-size
bot
added
size/M
github-actions
bot
removed
the
documentation
ericbn
commented
Aug 13, 2024
examples/middleware_factory/src/getting_started_middleware_tracer_function.py
Outdated
Show resolved
Hide resolved
leandrodamascena
force-pushed
the
middleware_factory_annotations
branch
from
5a28f8b to
9db63ef
Compare
pull-request-size
bot
added
size/XS
pull-request-size
bot
added
size/S
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #4951
Summary
Changes
Add
from __future__ import annotationsto middleware_factory packageUser experience
Discussed in #4607
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.