Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed Nested reference for TagProperty #152

Merged
merged 2 commits into from
May 9, 2024
Merged

Allowed Nested reference for TagProperty #152

merged 2 commits into from
May 9, 2024

Conversation

ammokhov
Copy link
Contributor

@ammokhov ammokhov commented May 9, 2024

Issue #, if available:

Description of changes:

This code change enhances validation of the tagProperty.

  1. Validates if there is a correct pointer specified
  2. Validates if reference uses correct notation (must start with /properties/)
  3. Allows tags to be nested properties.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammokhov ammokhov self-assigned this May 9, 2024
@ammokhov ammokhov added the enhancement New feature or request label May 9, 2024
@ammokhov ammokhov merged commit 7db1488 into master May 9, 2024
1 check passed
@ammokhov ammokhov deleted the tagProperty-enhancement branch May 9, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AidenAtSea AidenAtSea AidenAtSea approved these changes

@himanshs23 himanshs23 himanshs23 approved these changes

@bcorman3 bcorman3 bcorman3 approved these changes

@wenyez wenyez wenyez approved these changes

@joshuadeanhall joshuadeanhall Awaiting requested review from joshuadeanhall

Assignees

@ammokhov ammokhov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ammokhov @AidenAtSea @himanshs23 @bcorman3 @wenyez