Stop logging event data #117
Conversation
| @@ -586,7 +586,6 @@ export abstract class BaseResource< | |||
| this.prepareCredentialsFilter(this.callerSession) | |||
| ); | |||
| } | |||
| this.log('EVENT DATA\n', eventData); | |||
There was a problem hiding this comment.
Yes, this is the only place logging event data in the repo.
There was a problem hiding this comment.
Validated this is the only place logging event data by invoking CUD handlers of a resource.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
==========================================
- Coverage 98.56% 98.55% -0.01%
==========================================
Files 14 14
Lines 1250 1249 -1
Branches 209 209
==========================================
- Hits 1232 1231 -1
Misses 17 17
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Hi @rajdivya , what was the reasoning behind this? I use EVENT DATA log for various debugging reasons. It was helpful to get insight into how the cloudformation event looked like. |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.