test: wait for IAM role propagation in migration test #14060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
force-pushed
the
guest/data/palpatim.troubleshoot.policies-with-overrides
branch
4 times, most recently
from
b261865 to
c30a9a4
Compare
palpatim
force-pushed
the
guest/data/palpatim.troubleshoot.policies-with-overrides
branch
from
c30a9a4 to
d03341d
Compare
palpatim
force-pushed
the
guest/data/palpatim.troubleshoot.policies-with-overrides
branch
from
d03341d to
daa32ce
Compare
sobolk
approved these changes
Jan 8, 2025
ShadowCat567
approved these changes
Jan 8, 2025
sobolk
deleted the
guest/data/palpatim.troubleshoot.policies-with-overrides
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add a hardcoded delay in
model-migration.test.tsto account for IAM role propagation. (I experimented with using an IAM waiter rather than a hardcoded delay, but couldn't get it to work in my local environment in the time I allocated for investigation. 20s seems a reasonable price to pay on a ~1600s total test run.)Other changes
USE_FIDO_KEYenvironment variable when invoking cloud utilities, to add the-fflag tomwinitinvocations.Issue #, if available
Description of how you validated changes
The
model-migration.test.tsE2E test, which was previously reliably failing on Linux after applying new Data package versions, now passes reliably in both Linux & Windows.Checklist
yarn testpassesdevBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.