Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin cypress version in uibuilder test #14042

Closed
wants to merge 3 commits into from
Closed

fix: pin cypress version in uibuilder test #14042

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21f6ac6
fix: pin cypress version when running from npx
awsluja Dec 16, 2024
6c956b2
fix: pin install version of cypress
awsluja Dec 16, 2024
8d39648
chore: downgrade to 13.15.0
awsluja Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/amplify-e2e-tests/src/__tests__/uibuilder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ describe('amplify pull with uibuilder', () => {
spawnSync(
getNpmPath(),
// in some runs spawnSync/npx will still use an old ver of react-scripts moving it into npm install flow
['install', '-E', '@types/react', 'cypress', '@aws-amplify/ui-react', 'aws-amplify', 'react-scripts@5'],
['install', '-E', '@types/react', 'cypress@13.15.0', '@aws-amplify/ui-react', 'aws-amplify', 'react-scripts@5'],
{ cwd: reactDir },
);

Expand All @@ -114,7 +114,7 @@ describe('amplify pull with uibuilder', () => {
const npmStartProcess = spawn(getNpmPath(), ['start'], { cwd: reactDir, timeout: 300000 });
// Give react server time to start
await new Promise((resolve) => setTimeout(resolve, 60000));
const res = execa.sync(getNpxPath(), ['cypress', 'run'], { cwd: reactDir, encoding: 'utf8' });
const res = execa.sync(getNpxPath(), ['cypress@13.15.0', 'run'], { cwd: reactDir, encoding: 'utf8' });
// kill the react server process
spawnSync('kill', [`${npmStartProcess.pid}`], { encoding: 'utf8' });
await new Promise((resolve) => setTimeout(resolve, 1000));
Expand Down
Loading