MBS-8436 enable kotlin warnings as errors (#638)

* MBS-8436 enable kotlin warnings as errors

* MBS-8436 fix test warnings

subprojects/android-test/test-inhouse-runner/src/main/kotlin/com/avito/android/runner/InHouseInstrumentationTestRunner.kt

@@ -298,7 +298,7 @@ abstract class InHouseInstrumentationTestRunner :
         )
     }
 
-    private fun validateEnvironment(runEnvironment: TestRunEnvironment.RunEnvironment) {
+    private fun validateEnvironment(@Suppress("UNUSED_PARAMETER") runEnvironment: TestRunEnvironment.RunEnvironment) {
         //todo validate
     }
 

subprojects/android-test/test-inhouse-runner/src/main/kotlin/com/avito/android/runner/PlayServices.kt

@@ -21,6 +21,7 @@ internal fun Context.checkPlayServices() {
     }
 }
 
+@Suppress("DEPRECATION")
 internal val Context.playServicesOnDeviceVersion: Int
     get() = packageManager.getPackageInfo(GoogleApiAvailability.GOOGLE_PLAY_SERVICES_PACKAGE, 0).versionCode
 

subprojects/android-test/test-inhouse-runner/src/test/kotlin/com/avito/android/runner/annotation/resolver/AnnotationsTest.kt

@@ -4,10 +4,10 @@ import com.test.fixtures.TestAnnotation1
 import com.test.fixtures.TestAnnotation2
 import com.test.fixtures.TestAnnotation3
 import com.test.fixtures.TestAnnotation4
+import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers
 import org.hamcrest.Matchers.allOf
 import org.hamcrest.Matchers.hasSize
-import org.junit.Assert.assertThat
 import org.junit.jupiter.api.Test
 import ru.avito.util.matcher.containsValueWithType
 

subprojects/android-test/test-inhouse-runner/src/test/kotlin/com/avito/android/runner/annotation/resolver/MethodStringRepresentationTest.kt

@@ -6,7 +6,7 @@ import com.avito.android.runner.annotation.resolver.MethodStringRepresentation.R
 import com.avito.android.runner.annotation.resolver.MethodStringRepresentation.Resolution.ParseError
 import com.test.fixtures.ClassWithMethod
 import org.hamcrest.CoreMatchers.equalTo
-import org.junit.Assert.assertThat
+import org.hamcrest.MatcherAssert.assertThat
 import org.junit.jupiter.api.Test
 
 class MethodStringRepresentationTest {

subprojects/android-test/test-report/src/main/kotlin/com/avito/android/test/report/listener/TestLifecycleListener.kt

@@ -17,7 +17,7 @@ interface TestLifecycleListener {
         //do nothing
     }
 
-    fun afterTestStop(result: ReportState.Initialized.Started) {
+    fun afterTestStop(state: ReportState.Initialized.Started) {
         //do nothing
     }
 
@@ -55,8 +55,8 @@ object TestLifecycleNotifier : TestLifecycleListener {
         listeners.forEach { it.afterTestUpdate(state) }
     }
 
-    override fun afterTestStop(result: ReportState.Initialized.Started) {
-        listeners.forEach { it.afterTestStop(result) }
+    override fun afterTestStop(state: ReportState.Initialized.Started) {
+        listeners.forEach { it.afterTestStop(state) }
     }
 
     override fun beforeTestWrite(state: ReportState.Initialized.Started) {

subprojects/android-test/test-report/src/main/kotlin/com/avito/android/test/report/video/VideoCapturer.kt

@@ -132,11 +132,11 @@ class VideoCapturerImpl(
         return binary.absolutePath
     }
 
-    fun File.createOrClear() {
+    private fun File.createOrClear() {
         if (exists()) {
             writer().use { it.write("") }
         } else {
-            parentFile.mkdirs()
+            parentFile?.mkdirs()
             createNewFile()
         }
     }

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/Device.kt

@@ -17,12 +17,12 @@ import com.avito.android.test.internal.Cache
 import com.avito.android.test.internal.SQLiteDB
 import com.avito.android.test.internal.SharedPreferences
 import com.avito.android.test.page_object.KeyboardElement
-import junit.framework.Assert.assertEquals
-import junit.framework.Assert.assertTrue
 import org.hamcrest.CoreMatchers
 import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.containsString
 import org.hamcrest.Matchers.not
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertTrue
 
 /**
  * Abstraction of android phone from user's perspective

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/checks/ChecksImpl.kt

@@ -88,11 +88,11 @@ class ChecksImpl(private val driver: ChecksDriver) : Checks,
     }
 
     override fun isLeftOf(matcher: Matcher<View>) {
-        driver.check(PositionAssertions.isLeftOf(matcher))
+        driver.check(PositionAssertions.isCompletelyLeftOf(matcher))
     }
 
     override fun isRightOf(matcher: Matcher<View>) {
-        driver.check(PositionAssertions.isRightOf(matcher))
+        driver.check(PositionAssertions.isCompletelyRightOf(matcher))
     }
 
     override fun isLeftAlignedWith(matcher: Matcher<View>) {
@@ -104,11 +104,11 @@ class ChecksImpl(private val driver: ChecksDriver) : Checks,
     }
 
     override fun isAbove(matcher: Matcher<View>) {
-        driver.check(PositionAssertions.isAbove(matcher))
+        driver.check(PositionAssertions.isCompletelyAbove(matcher))
     }
 
     override fun isBelow(matcher: Matcher<View>) {
-        driver.check(PositionAssertions.isBelow(matcher))
+        driver.check(PositionAssertions.isCompletelyBelow(matcher))
     }
 
     override fun isBottomAlignedWith(matcher: Matcher<View>) {

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/checks/OnViewChecksDriver.kt

@@ -9,7 +9,9 @@ import com.avito.android.test.interceptor.AssertionInterceptor
 import com.avito.android.test.waitForCheck
 import org.hamcrest.Matcher
 
-@Deprecated("todo use InteractionContext")
+/**
+ * use interactionContext instead
+ */
 class OnViewChecksDriver(private val matcher: Matcher<View>) : ChecksDriver {
 
     private val interaction: ViewInteraction

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/internal/Cache.kt

@@ -2,8 +2,8 @@ package com.avito.android.test.internal
 
 import android.content.Context
 import com.avito.android.waiter.waitFor
+import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.`is`
-import org.junit.Assert
 import java.io.File
 
 internal class Cache(private val appContext: Context) {
@@ -12,7 +12,7 @@ internal class Cache(private val appContext: Context) {
         val cacheDir = appContext.cacheDir
         if (cacheDir.list() != null) {
             waitFor(frequencyMs = DELETE_FREQUENCY_MS, timeoutMs = DELETE_TIMEOUT_MS) {
-                Assert.assertThat(
+                assertThat(
                     "Can't delete ${cacheDir.path}",
                     deleteRecursive(cacheDir),
                     `is`(true)
@@ -29,7 +29,7 @@ internal class Cache(private val appContext: Context) {
         if (directory.isDirectory) {
             directory.list()?.forEach { content ->
                 waitFor(frequencyMs = DELETE_FREQUENCY_MS, timeoutMs = DELETE_TIMEOUT_MS) {
-                    Assert.assertThat(
+                    assertThat(
                         "Can't delete file $content in ${directory.path}",
                         deleteRecursive(File(directory, content), *excludes),
                         `is`(true)

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/internal/SQLiteDB.kt

@@ -1,8 +1,8 @@
 package com.avito.android.test.internal
 
 import android.content.Context
+import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.`is`
-import org.junit.Assert
 
 internal class SQLiteDB(private val appContext: Context) {
 
@@ -16,7 +16,7 @@ internal class SQLiteDB(private val appContext: Context) {
             appContext.deleteDatabase(database)
 
             val exists = databasePath.exists()
-            Assert.assertThat("db exist not anymore at $databasePath", exists, `is`(false))
+            assertThat("db exist not anymore at $databasePath", exists, `is`(false))
         }
     }
 }

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/matcher/ImageShownMatcher.kt

@@ -5,13 +5,13 @@ import android.widget.ImageView
 import androidx.test.espresso.matcher.BoundedMatcher
 import org.hamcrest.Description
 
-class ImageShownMatcher :
-    BoundedMatcher<View, ImageView>(ImageView::class.java) {
+class ImageShownMatcher : BoundedMatcher<View, ImageView>(ImageView::class.java) {
 
     override fun describeTo(description: Description) {
         description.appendText("with shown image: ")
     }
 
+    @Suppress("DEPRECATION")
     override fun matchesSafely(layout: ImageView): Boolean {
         layout.isDrawingCacheEnabled = true
 

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/matcher/NoViewMatcher.kt

@@ -4,12 +4,14 @@ import android.view.View
 import org.hamcrest.Description
 import org.hamcrest.TypeSafeMatcher
 
-@Deprecated("Used to refactor PageObjectElement matcher constructor")
+/**
+ * Used to refactor PageObjectElement matcher constructor
+ */
 class NoViewMatcher : TypeSafeMatcher<View>() {
     override fun describeTo(description: Description) {
         description.appendText(
             " If you see this description: you use legacy PageObjectElement constructor; " +
-                    "It is forbidden for now, because it doesn't respect interaction context"
+                "It is forbidden for now, because it doesn't respect interaction context"
         )
     }
 

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/page_object/BottomSheetElement.kt

@@ -1,22 +1,18 @@
 package com.avito.android.test.page_object
 
 import androidx.test.espresso.assertion.ViewAssertions
-import android.view.View
+import com.avito.android.test.InteractionContext
 import com.avito.android.test.checks.Checks
 import com.avito.android.test.checks.ChecksDriver
 import com.avito.android.test.checks.ChecksImpl
-import com.avito.android.test.checks.OnViewChecksDriver
 import com.avito.android.test.matcher.BottomSheetCollapsedMatcher
 import com.avito.android.test.matcher.BottomSheetExpandedMatcher
-import org.hamcrest.Matcher
 
-open class BottomSheetElement(matcher: Matcher<View>) : ViewElement(matcher) {
+open class BottomSheetElement(interactionContext: InteractionContext) : ViewElement(interactionContext) {
 
-    override val checks = ElementChecks()
+    override val checks = ElementChecks(interactionContext)
 
-    inner class ElementChecks(
-        private val drivenChecks: ChecksDriver = OnViewChecksDriver(matcher)
-    ) : Checks by ChecksImpl(drivenChecks) {
+    inner class ElementChecks(private val drivenChecks: ChecksDriver) : Checks by ChecksImpl(drivenChecks) {
 
         fun isExpanded() {
             drivenChecks.check(ViewAssertions.matches(BottomSheetExpandedMatcher()))
@@ -25,6 +21,5 @@ open class BottomSheetElement(matcher: Matcher<View>) : ViewElement(matcher) {
         fun isCollapsed() {
             drivenChecks.check(ViewAssertions.matches(BottomSheetCollapsedMatcher()))
         }
-
     }
 }

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/page_object/KeyboardElement.kt

@@ -6,8 +6,8 @@ import android.view.View
 import androidx.test.espresso.Espresso
 import androidx.test.espresso.action.ViewActions
 import androidx.test.platform.app.InstrumentationRegistry
+import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.`is`
-import org.junit.Assert
 
 class KeyboardElement : PageObject() {
 
@@ -70,7 +70,7 @@ class KeyboardElement : PageObject() {
                     if (get(content) == null) {
                         throw RuntimeException(
                             "Can't check keyboard position. Because View::mAttachInfo is null." +
-                                    " Did you rotate screen in test before this check?"
+                                " Did you rotate screen in test before this check?"
                         )
                     }
                 }
@@ -82,7 +82,7 @@ class KeyboardElement : PageObject() {
                 threshold = (activityHeight - minimalKeyboardHeight).toInt()
             }
 
-            Assert.assertThat(
+            assertThat(
                 generateErrorMessage(
                     displayed = isOpen,
                     activityEffectiveHeight = activityEffectiveHeight,
@@ -107,7 +107,7 @@ class KeyboardElement : PageObject() {
                     }
                     val sizes =
                         " actualEffectiveHeight: $activityEffectiveHeight " +
-                                "thresholdEffectiveHeight: $threshold"
+                            "thresholdEffectiveHeight: $threshold"
 
                     "(keyboard $status on the screen.${if (withSizes) sizes else ""})"
                 }
@@ -116,7 +116,7 @@ class KeyboardElement : PageObject() {
             val expected = "Expected:"
 
             return "${getStatusMessage(!displayed, true)} $doesNotMatch" +
-                    " $expected ${getStatusMessage(displayed, false)}"
+                " $expected ${getStatusMessage(displayed, false)}"
         }
     }
 }

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/page_object/ListElement.kt

@@ -78,7 +78,7 @@ open class ListElement(interactionContext: InteractionContext) : ViewElement(int
     /**
      * Hide parent method [PageObject.element]
      */
-    protected inline fun <reified T : PageObjectElement> element(matcher: Matcher<View>): T =
+    protected inline fun <reified T : PageObjectElement> element(@Suppress("UNUSED_PARAMETER") matcher: Matcher<View>): T =
         throw RuntimeException("Use listElement(Matcher<View>) instead of element(Matcher<View>)")
 
     /**

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/page_object/PageObjectElement.kt

@@ -5,10 +5,11 @@ import com.avito.android.test.action.Actions
 import com.avito.android.test.checks.Checks
 import org.hamcrest.Matcher
 
-
 // TODO: hide or deprecate private api
 abstract class PageObjectElement : PageObject(), Actions {
-    @Deprecated("Don't use this matcher directly. Make child interaction context instead.")
+    /**
+     * Don't use this matcher directly. Make child interaction context instead.
+     */
     abstract val matcher: Matcher<View>
     abstract val actions: Actions
     abstract val checks: Checks

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/page_object/ViewElement.kt

@@ -20,10 +20,12 @@ open class ViewElement : PageObjectElement, Actions {
     override val actions: Actions
     override val checks: Checks
 
-    // TODO: make this constructor private and remove matcher
-    @Deprecated("Don't use this constructor. It leads to actions and checks in a wrong screen. " +
-        "Inside [PageObject] use [element] to create an instance with child interaction context. " +
-        "From custom class use ViewElement(interactionContext)")
+    /**
+     * TODO: make this constructor private and remove matcher
+     * Don't use this constructor. It leads to actions and checks in a wrong screen. " +
+    "Inside [PageObject] use [element] to create an instance with child interaction context. " +
+    "From custom class use ViewElement(interactionContext)
+     */
     constructor(
         matcher: Matcher<View>,
         interactionContext: InteractionContext = SimpleInteractionContext(matcher),
@@ -53,7 +55,8 @@ open class ViewElement : PageObjectElement, Actions {
 
     override fun scrollTo() = actions.scrollTo()
 
-    override fun swipe(direction: SwipeDirection, speed: Swiper, precision: PrecisionDescriber) = actions.swipe(direction, speed, precision)
+    override fun swipe(direction: SwipeDirection, speed: Swiper, precision: PrecisionDescriber) =
+        actions.swipe(direction, speed, precision)
 
     override fun read(allowBlank: Boolean) = actions.read(allowBlank)
 }

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/page_object/ViewPagerElement.kt

@@ -41,10 +41,10 @@ open class ViewPagerElement(
     /**
      * Hide parent method [PageObject.element]
      */
-    protected inline fun <reified T : PageObjectElement> element(matcher: Matcher<View>): T =
+    protected inline fun <reified T : PageObjectElement> element(@Suppress("UNUSED_PARAMETER") matcher: Matcher<View>): T =
         throw RuntimeException(
             "Use currentPageElement(Matcher<View>) instead for getting page of view pager" +
-                    "and then use element(Matcher<View>) for getting child"
+                "and then use element(Matcher<View>) for getting child"
         )
 
     /**
@@ -53,7 +53,7 @@ open class ViewPagerElement(
     protected inline fun <reified T : PageObjectElement> element(): T =
         throw RuntimeException(
             "Use currentPageElement(Matcher<View>) instead for getting page of view pager" +
-                    "and then use element(Matcher<View>) for getting child"
+                "and then use element(Matcher<View>) for getting child"
         )
 }
 

subprojects/android-test/ui-testing-core/src/main/kotlin/com/avito/android/test/util/Reflection.kt

@@ -9,7 +9,7 @@ internal fun <T> Any.getFieldByReflection(fieldName: String): T =
 internal fun Any.getFieldByReflectionWithAnyField(fieldName: String): Any =
     this::class.java.getDeclaredField(fieldName)
         .also { it.isAccessible = true }
-        .get(this)
+        .get(this)!!
 
 internal fun Any.executeMethod(method: String, vararg arguments: Any?) =
     javaClass.methods

subprojects/android-test/ui-testing-maps/src/main/kotlin/com.avito.android.test.maps/GoogleMapActions.kt

@@ -5,7 +5,7 @@ import com.avito.android.test.maps.provider.GoogleMapProvider
 import com.avito.android.test.waitFor
 import com.google.android.gms.maps.CameraUpdateFactory
 import com.google.android.gms.maps.model.LatLng
-import org.junit.Assert
+import org.hamcrest.MatcherAssert.assertThat
 
 interface GoogleMapActions {
     fun movePinTo(position: LatLng)
@@ -27,7 +27,7 @@ class GoogleMapActionsImpl(
 
             waitFor(timeoutMs = timeoutMs) {
                 UiThreadStatement.runOnUiThread {
-                    Assert.assertThat(
+                    assertThat(
                         map.cameraPosition.target,
                         hasTheSameCoordinatesAs(position)
                     )