Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use include_tasks since include is deprecated. #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tyler-8
Copy link

@tyler-8 tyler-8 commented May 16, 2018

[DEPRECATION WARNING]: The use of 'include' for tasks has been deprecated. Use 'import_tasks' for static inclusions or 'include_tasks' for dynamic inclusions. This feature will be removed in a future release. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
[DEPRECATION WARNING]: include is kept for backwards compatibility but usage is discouraged. The module documentation details page may explain more about this rationale.. This feature will be removed in a future release. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

@avanov
Copy link
Owner

avanov commented May 17, 2018

Hi @tyler-8, I'm happy to merge it if you fix the currently failing CI test (needs altering .travis.yml) and resolve conflicts.

@tyler-8
Copy link
Author

tyler-8 commented May 18, 2018

Looks like I can't fix those errors as include_tasks was introduced in Ansible 2.4 and the CI test is with Ansible 1.9.

@avanov
Copy link
Owner

avanov commented May 18, 2018

@tyler-8 yes, so could you edit the .travis.yml and put 2.0 instead of 1.9. It should be fine since we're explicitly saying that the lower version supported is 2.0 in https://github.com/avanov/ansible-galaxy-pyenv/blob/master/meta/main.yml#L14

@tyler-8
Copy link
Author

tyler-8 commented May 18, 2018

Sorry I'm not very familiar with TravisCI (still new at this stuff). Is there a way to specify another test entirely, since 2.0 still wouldn't be high enough for include_tasks.

@avanov
Copy link
Owner

avanov commented May 21, 2018

@tyler-8 what's the least required version for this syntax?

@tyler-8
Copy link
Author

tyler-8 commented May 23, 2018

Per the Ansible documentation, it was introduced in Ansible 2.4.0 (released September 2017) along with a depreciation message (seen in my OP).

@avanov
Copy link
Owner

avanov commented May 23, 2021

@tyler-8 it's been a while since the original report, but if that change is still of interest to you, could you rebase your changes on the current master branch?

diraol added a commit to diraol/ansible-galaxy-pyenv that referenced this pull request Mar 16, 2022
Basically the same as avanov#19, but rebased and updated.

credits to: @tyler-8

Closes avanov#19
diraol added a commit to diraol/ansible-galaxy-pyenv that referenced this pull request Mar 16, 2022
Basically the same as avanov#19, but rebased and updated.

credits to: @tyler-8

Closes avanov#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants