Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block hash publisher #51

Closed
wants to merge 28 commits into from
Closed

Block hash publisher #51

wants to merge 28 commits into from

Conversation

cam-schultz
Copy link
Contributor

Why this should be merged

Adds a basic contract that verifies a block hash from another chain, and emits it in an event, using the subnet-evm features described in ava-labs/subnet-evm#734.

How this was tested

Matthew Lam and others added 23 commits September 8, 2023 05:22
apply getVerifiedWarpMessage and sourceChainID changes
3120b71
Merge remote-tracking branch 'origin/main' into integrate-warp-changes
2eb3587
update subnet-evm commit to v0.5.6
4174ab2
update golang version and genesis template
2edfb9b
reformat genesis template
7ee3a09
add dupgrade config to genesis template
33b8d4c
add index to receiveCrossChainMessage
bd3656f
fix unit test
e496ee0
test added buffer gas
e72ddb9
add unit test for receive index
93ec7bd
fix comment
d6b1fe4
remove abi
9118693
update naming and parameter order
65b6110
@cam-schultz
Update contracts/src/Teleporter/ITeleporterMessenger.sol
00fc76a 
Co-authored-by: cam-schultz <[email protected]>
Signed-off-by: minghinmatthewlam <[email protected]>
@cam-schultz
basic block hash receiver
a52b2b9
@cam-schultz
Merge branch 'main' into block-hash-publisher
442e9d2
@cam-schultz
block hash go binding
c08725f
@cam-schultz
block hash packing
43ad4b3
@cam-schultz
Merge branch 'main' into block-hash-publisher
4544d91
@cam-schultz
Merge branch 'main' into block-hash-publisher
feb8fe1
@cam-schultz
cleanup var
9b7af3f
@cam-schultz
block hash receiver abigen
a8e949b
@cam-schultz
Merge branch 'main' into block-hash-publisher
cab06ce
@cam-schultz cam-schultz mentioned this pull request Oct 5, 2023
Draft
5 tasks
@cam-schultz cam-schultz marked this pull request as ready for review October 5, 2023 21:32
geoff-vball
geoff-vball reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@geoff-vball geoff-vball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the name of an error. Otherwise LGTM

contracts/src/Teleporter/TeleporterBlockHashReceiver.sol Outdated Show resolved Hide resolved
@michaelkaplan13
Copy link
Collaborator

Lets discuss whether or not we think these contracts belong in the teleporter repo. I understand the motivation (warp-related EVM contract), but it is the first time we'd be introducing contracts that don't relate to the TeleporterMessenger protocol.

Part of me thinks that the interface that the awm-relayer will call to deliver a block hash could live in the awm-relayer repo itself, and we could avoid any dependencies here.

bernard-avalabs
bernard-avalabs reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@bernard-avalabs bernard-avalabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally makes sense to me.

geoff-vball
geoff-vball previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@geoff-vball geoff-vball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

network_setup.go seems to be getting slightly unwieldy. I'll follow up this PR with a bit of a refactor that I've already mostly done in my native bridge branch. That way I can take it out of the native bridge PR to simplify it.

@geoff-vball geoff-vball dismissed their stale review November 21, 2023 16:16

Will need refactoring with new test code

@cam-schultz cam-schultz marked this pull request as draft December 6, 2023 15:05
@michaelkaplan13
Copy link
Collaborator

Closing this as stale, but the idea is still planned to be use as a part of ACP-108.

@michaelkaplan13 michaelkaplan13 deleted the block-hash-publisher branch August 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkaplan13 michaelkaplan13 michaelkaplan13 left review comments

@bernard-avalabs bernard-avalabs bernard-avalabs left review comments

@minghinmatthewlam minghinmatthewlam minghinmatthewlam left review comments

@geoff-vball geoff-vball geoff-vball left review comments

@gwen917 gwen917 Awaiting requested review from gwen917

Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cam-schultz @michaelkaplan13 @geoff-vball @minghinmatthewlam @bernard-avalabs